You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Adam Winer (JIRA)" <de...@myfaces.apache.org> on 2007/06/21 23:20:26 UTC
[jira] Created: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
trinidad-impl.jar file is left open during execution
----------------------------------------------------
Key: TRINIDAD-73
URL: https://issues.apache.org/jira/browse/TRINIDAD-73
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.0.1-core
Reporter: Adam Winer
Assignee: Adam Winer
When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Matthias Wessendorf <ma...@apache.org>.
On Mon, Sep 29, 2008 at 5:56 PM, Edward Dowgiallo <ed...@gmail.com> wrote:
> I can't get any of the releases imported to our development system
> until they go 'production' on the Apache site. I will try out the
I understand that.
> snapshot at home.
that was what I tried to say ;-) Try them at the development stage, not
production.
-M
>
> Ed
>
> On 9/29/08, Matthias Wessendorf <ma...@apache.org> wrote:
>> Hi Ed,
>>
>> there will be a release by end of October, that contains the fix.
>> Is it possible for you to test against a pretty recent snapshot of 1.2.10 ?
>> (or against 1.1.10 if you are on the JSF 1.1 side):
>>
>> http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-api/1.2.10-SNAPSHOT/
>> http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-impl/1.2.10-SNAPSHOT/
>>
>> -Matthias
>>
>> On Mon, Sep 29, 2008 at 5:26 PM, Edward Dowgiallo <ed...@gmail.com>
>> wrote:
>>> It's been about a month since I posted the previous message, any
>>> thoughts on the questions?
>>>
>>> Is there a workaround for Trinidad-73? Currently, it doesn't take too
>>> many users to crash Tomcat when we hit the maximum open files per
>>> process limit in z-Linux.
>>>
>>> Thank you,
>>> Ed
>>>
>>> On 8/25/08, Edward Dowgiallo <ed...@gmail.com> wrote:
>>>> We've been using a lot of include files in our JSF pages to sort of
>>>> simulate tiles. The open file handle issue is a show stopper for us.
>>>> When we tried a beta test with a relatively small group of people, we
>>>> overran the 1000 file handle limit on our OS process very quickly.
>>>> After hitting the limit, the Tomcat server crashed. We aren't really
>>>> effected in development, but just upping the file handles per process
>>>> isn't going to help us in production. Our user base is 10000+.
>>>>
>>>> Is the group aware of any Trinidad deployments involving large numbers
>>>> of users? Is Trinidad on Tomcat a viable environment for larger
>>>> numbers of users? Has any performance testing been done to see how
>>>> well the library scales?
>>>>
>>>> Ed
>>>>
>>>> On 8/25/08, Harald Kuhn (JIRA) <de...@myfaces.apache.org> wrote:
>>>>>
>>>>> [
>>>>> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333
>>>>> ]
>>>>>
>>>>> Harald Kuhn commented on TRINIDAD-73:
>>>>> -------------------------------------
>>>>>
>>>>> Thanks.
>>>>> This fix reduces the used file handles on first request from about 50 to
>>>>> 2.
>>>>> That's great.
>>>>>
>>>>> But I want to share two points I have noticed:
>>>>> 1) this fix seems to be useless if your webapp is deployed to Tomcat
>>>>> (Version 5.5.25) with option antiJARLocking="true".
>>>>> This might be a Tomcat issue.
>>>>>
>>>>> 2) There are still multiple file handles for the generated css files
>>>>> (Output of lsof)
>>>>> java 30914 tomcat 4r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 15r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 43r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 54r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 58r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 61r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 86r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 88r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>> java 30914 tomcat 97r REG 8,2 90191 833043
>>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>>
>>>>>> trinidad-impl.jar file is left open during execution
>>>>>> ----------------------------------------------------
>>>>>>
>>>>>> Key: TRINIDAD-73
>>>>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>>>>>> Project: MyFaces Trinidad
>>>>>> Issue Type: Bug
>>>>>> Affects Versions: 1.0.1-core
>>>>>> Reporter: Adam Winer
>>>>>> Assignee: Matthias Weßendorf
>>>>>> Fix For: 1.2.10-core, 1.0.10-core
>>>>>>
>>>>>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>>>>>> CachingResourceLoader-patch-on-549615.txt,
>>>>>> ProxyResourceLoader-patch-on-518820.txt,
>>>>>> ResourceServlet-patch-on-549620.txt,
>>>>>> URLInputStreamProvider-patch-on-549615.txt,
>>>>>> URLUtils-patch-on-660215.txt,
>>>>>> URLUtils.java
>>>>>>
>>>>>>
>>>>>> When running a Trinidad application, trinidad-impl.jar is getting
>>>>>> locked
>>>>>> with open FileInputStream objects. When GC occurs, the
>>>>>> FileInputStreams
>>>>>> are getting cleared, but as new FileInputStreams are opened on each
>>>>>> request, the file is eternally locked. Other files are likely getting
>>>>>> locked too.
>>>>>
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> -
>>>>> You can reply to this email to add a comment to the issue online.
>>>>>
>>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Edward Dowgiallo <ed...@gmail.com>.
I can't get any of the releases imported to our development system
until they go 'production' on the Apache site. I will try out the
snapshot at home.
Ed
On 9/29/08, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi Ed,
>
> there will be a release by end of October, that contains the fix.
> Is it possible for you to test against a pretty recent snapshot of 1.2.10 ?
> (or against 1.1.10 if you are on the JSF 1.1 side):
>
> http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-api/1.2.10-SNAPSHOT/
> http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-impl/1.2.10-SNAPSHOT/
>
> -Matthias
>
> On Mon, Sep 29, 2008 at 5:26 PM, Edward Dowgiallo <ed...@gmail.com>
> wrote:
>> It's been about a month since I posted the previous message, any
>> thoughts on the questions?
>>
>> Is there a workaround for Trinidad-73? Currently, it doesn't take too
>> many users to crash Tomcat when we hit the maximum open files per
>> process limit in z-Linux.
>>
>> Thank you,
>> Ed
>>
>> On 8/25/08, Edward Dowgiallo <ed...@gmail.com> wrote:
>>> We've been using a lot of include files in our JSF pages to sort of
>>> simulate tiles. The open file handle issue is a show stopper for us.
>>> When we tried a beta test with a relatively small group of people, we
>>> overran the 1000 file handle limit on our OS process very quickly.
>>> After hitting the limit, the Tomcat server crashed. We aren't really
>>> effected in development, but just upping the file handles per process
>>> isn't going to help us in production. Our user base is 10000+.
>>>
>>> Is the group aware of any Trinidad deployments involving large numbers
>>> of users? Is Trinidad on Tomcat a viable environment for larger
>>> numbers of users? Has any performance testing been done to see how
>>> well the library scales?
>>>
>>> Ed
>>>
>>> On 8/25/08, Harald Kuhn (JIRA) <de...@myfaces.apache.org> wrote:
>>>>
>>>> [
>>>> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333
>>>> ]
>>>>
>>>> Harald Kuhn commented on TRINIDAD-73:
>>>> -------------------------------------
>>>>
>>>> Thanks.
>>>> This fix reduces the used file handles on first request from about 50 to
>>>> 2.
>>>> That's great.
>>>>
>>>> But I want to share two points I have noticed:
>>>> 1) this fix seems to be useless if your webapp is deployed to Tomcat
>>>> (Version 5.5.25) with option antiJARLocking="true".
>>>> This might be a Tomcat issue.
>>>>
>>>> 2) There are still multiple file handles for the generated css files
>>>> (Output of lsof)
>>>> java 30914 tomcat 4r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 15r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 43r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 54r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 58r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 61r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 86r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 88r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>> java 30914 tomcat 97r REG 8,2 90191 833043
>>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>>
>>>>> trinidad-impl.jar file is left open during execution
>>>>> ----------------------------------------------------
>>>>>
>>>>> Key: TRINIDAD-73
>>>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>>>>> Project: MyFaces Trinidad
>>>>> Issue Type: Bug
>>>>> Affects Versions: 1.0.1-core
>>>>> Reporter: Adam Winer
>>>>> Assignee: Matthias Weßendorf
>>>>> Fix For: 1.2.10-core, 1.0.10-core
>>>>>
>>>>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>>>>> CachingResourceLoader-patch-on-549615.txt,
>>>>> ProxyResourceLoader-patch-on-518820.txt,
>>>>> ResourceServlet-patch-on-549620.txt,
>>>>> URLInputStreamProvider-patch-on-549615.txt,
>>>>> URLUtils-patch-on-660215.txt,
>>>>> URLUtils.java
>>>>>
>>>>>
>>>>> When running a Trinidad application, trinidad-impl.jar is getting
>>>>> locked
>>>>> with open FileInputStream objects. When GC occurs, the
>>>>> FileInputStreams
>>>>> are getting cleared, but as new FileInputStreams are opened on each
>>>>> request, the file is eternally locked. Other files are likely getting
>>>>> locked too.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> You can reply to this email to add a comment to the issue online.
>>>>
>>>>
>>>
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi Ed,
there will be a release by end of October, that contains the fix.
Is it possible for you to test against a pretty recent snapshot of 1.2.10 ?
(or against 1.1.10 if you are on the JSF 1.1 side):
http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-api/1.2.10-SNAPSHOT/
http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/trinidad/trinidad-impl/1.2.10-SNAPSHOT/
-Matthias
On Mon, Sep 29, 2008 at 5:26 PM, Edward Dowgiallo <ed...@gmail.com> wrote:
> It's been about a month since I posted the previous message, any
> thoughts on the questions?
>
> Is there a workaround for Trinidad-73? Currently, it doesn't take too
> many users to crash Tomcat when we hit the maximum open files per
> process limit in z-Linux.
>
> Thank you,
> Ed
>
> On 8/25/08, Edward Dowgiallo <ed...@gmail.com> wrote:
>> We've been using a lot of include files in our JSF pages to sort of
>> simulate tiles. The open file handle issue is a show stopper for us.
>> When we tried a beta test with a relatively small group of people, we
>> overran the 1000 file handle limit on our OS process very quickly.
>> After hitting the limit, the Tomcat server crashed. We aren't really
>> effected in development, but just upping the file handles per process
>> isn't going to help us in production. Our user base is 10000+.
>>
>> Is the group aware of any Trinidad deployments involving large numbers
>> of users? Is Trinidad on Tomcat a viable environment for larger
>> numbers of users? Has any performance testing been done to see how
>> well the library scales?
>>
>> Ed
>>
>> On 8/25/08, Harald Kuhn (JIRA) <de...@myfaces.apache.org> wrote:
>>>
>>> [
>>> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333
>>> ]
>>>
>>> Harald Kuhn commented on TRINIDAD-73:
>>> -------------------------------------
>>>
>>> Thanks.
>>> This fix reduces the used file handles on first request from about 50 to
>>> 2.
>>> That's great.
>>>
>>> But I want to share two points I have noticed:
>>> 1) this fix seems to be useless if your webapp is deployed to Tomcat
>>> (Version 5.5.25) with option antiJARLocking="true".
>>> This might be a Tomcat issue.
>>>
>>> 2) There are still multiple file handles for the generated css files
>>> (Output of lsof)
>>> java 30914 tomcat 4r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 15r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 43r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 54r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 58r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 61r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 86r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 88r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>> java 30914 tomcat 97r REG 8,2 90191 833043
>>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>>
>>>> trinidad-impl.jar file is left open during execution
>>>> ----------------------------------------------------
>>>>
>>>> Key: TRINIDAD-73
>>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>>>> Project: MyFaces Trinidad
>>>> Issue Type: Bug
>>>> Affects Versions: 1.0.1-core
>>>> Reporter: Adam Winer
>>>> Assignee: Matthias Weßendorf
>>>> Fix For: 1.2.10-core, 1.0.10-core
>>>>
>>>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>>>> CachingResourceLoader-patch-on-549615.txt,
>>>> ProxyResourceLoader-patch-on-518820.txt,
>>>> ResourceServlet-patch-on-549620.txt,
>>>> URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt,
>>>> URLUtils.java
>>>>
>>>>
>>>> When running a Trinidad application, trinidad-impl.jar is getting locked
>>>> with open FileInputStream objects. When GC occurs, the FileInputStreams
>>>> are getting cleared, but as new FileInputStreams are opened on each
>>>> request, the file is eternally locked. Other files are likely getting
>>>> locked too.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Edward Dowgiallo <ed...@gmail.com>.
It's been about a month since I posted the previous message, any
thoughts on the questions?
Is there a workaround for Trinidad-73? Currently, it doesn't take too
many users to crash Tomcat when we hit the maximum open files per
process limit in z-Linux.
Thank you,
Ed
On 8/25/08, Edward Dowgiallo <ed...@gmail.com> wrote:
> We've been using a lot of include files in our JSF pages to sort of
> simulate tiles. The open file handle issue is a show stopper for us.
> When we tried a beta test with a relatively small group of people, we
> overran the 1000 file handle limit on our OS process very quickly.
> After hitting the limit, the Tomcat server crashed. We aren't really
> effected in development, but just upping the file handles per process
> isn't going to help us in production. Our user base is 10000+.
>
> Is the group aware of any Trinidad deployments involving large numbers
> of users? Is Trinidad on Tomcat a viable environment for larger
> numbers of users? Has any performance testing been done to see how
> well the library scales?
>
> Ed
>
> On 8/25/08, Harald Kuhn (JIRA) <de...@myfaces.apache.org> wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333
>> ]
>>
>> Harald Kuhn commented on TRINIDAD-73:
>> -------------------------------------
>>
>> Thanks.
>> This fix reduces the used file handles on first request from about 50 to
>> 2.
>> That's great.
>>
>> But I want to share two points I have noticed:
>> 1) this fix seems to be useless if your webapp is deployed to Tomcat
>> (Version 5.5.25) with option antiJARLocking="true".
>> This might be a Tomcat issue.
>>
>> 2) There are still multiple file handles for the generated css files
>> (Output of lsof)
>> java 30914 tomcat 4r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 15r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 43r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 54r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 58r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 61r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 86r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 88r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>> java 30914 tomcat 97r REG 8,2 90191 833043
>> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>>
>>> trinidad-impl.jar file is left open during execution
>>> ----------------------------------------------------
>>>
>>> Key: TRINIDAD-73
>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>>> Project: MyFaces Trinidad
>>> Issue Type: Bug
>>> Affects Versions: 1.0.1-core
>>> Reporter: Adam Winer
>>> Assignee: Matthias Weßendorf
>>> Fix For: 1.2.10-core, 1.0.10-core
>>>
>>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>>> CachingResourceLoader-patch-on-549615.txt,
>>> ProxyResourceLoader-patch-on-518820.txt,
>>> ResourceServlet-patch-on-549620.txt,
>>> URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt,
>>> URLUtils.java
>>>
>>>
>>> When running a Trinidad application, trinidad-impl.jar is getting locked
>>> with open FileInputStream objects. When GC occurs, the FileInputStreams
>>> are getting cleared, but as new FileInputStreams are opened on each
>>> request, the file is eternally locked. Other files are likely getting
>>> locked too.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Edward Dowgiallo <ed...@gmail.com>.
We've been using a lot of include files in our JSF pages to sort of
simulate tiles. The open file handle issue is a show stopper for us.
When we tried a beta test with a relatively small group of people, we
overran the 1000 file handle limit on our OS process very quickly.
After hitting the limit, the Tomcat server crashed. We aren't really
effected in development, but just upping the file handles per process
isn't going to help us in production. Our user base is 10000+.
Is the group aware of any Trinidad deployments involving large numbers
of users? Is Trinidad on Tomcat a viable environment for larger
numbers of users? Has any performance testing been done to see how
well the library scales?
Ed
On 8/25/08, Harald Kuhn (JIRA) <de...@myfaces.apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333
> ]
>
> Harald Kuhn commented on TRINIDAD-73:
> -------------------------------------
>
> Thanks.
> This fix reduces the used file handles on first request from about 50 to 2.
> That's great.
>
> But I want to share two points I have noticed:
> 1) this fix seems to be useless if your webapp is deployed to Tomcat
> (Version 5.5.25) with option antiJARLocking="true".
> This might be a Tomcat issue.
>
> 2) There are still multiple file handles for the generated css files
> (Output of lsof)
> java 30914 tomcat 4r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 15r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 43r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 54r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 58r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 61r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 86r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 88r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> java 30914 tomcat 97r REG 8,2 90191 833043
> /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
>
>> trinidad-impl.jar file is left open during execution
>> ----------------------------------------------------
>>
>> Key: TRINIDAD-73
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>> Project: MyFaces Trinidad
>> Issue Type: Bug
>> Affects Versions: 1.0.1-core
>> Reporter: Adam Winer
>> Assignee: Matthias Weßendorf
>> Fix For: 1.2.10-core, 1.0.10-core
>>
>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>> CachingResourceLoader-patch-on-549615.txt,
>> ProxyResourceLoader-patch-on-518820.txt,
>> ResourceServlet-patch-on-549620.txt,
>> URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt,
>> URLUtils.java
>>
>>
>> When running a Trinidad application, trinidad-impl.jar is getting locked
>> with open FileInputStream objects. When GC occurs, the FileInputStreams
>> are getting cleared, but as new FileInputStreams are opened on each
>> request, the file is eternally locked. Other files are likely getting
>> locked too.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open during execution
Posted by Edward Dowgiallo <ed...@gmail.com>.
I've read the comments for this issue. May I assume that the Trinidad
fixes will be in the 1.0.9/1.2.9 release?
Thank you,
Ed
On 5/27/08, Thomas Jacob (JIRA) <de...@myfaces.apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600099#action_12600099
> ]
>
> Thomas Jacob commented on TRINIDAD-73:
> --------------------------------------
>
> ... I have set a breakpoint in the errorneous JDK method, and
> unfortunatelly, the method is still getting called. Now by MyFaces... I fear
> the story continues...
>
>> trinidad-impl.jar file is left open during execution
>> ----------------------------------------------------
>>
>> Key: TRINIDAD-73
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
>> Project: MyFaces Trinidad
>> Issue Type: Bug
>> Affects Versions: 1.0.1-core
>> Reporter: Adam Winer
>> Fix For: 1.0.2-core
>>
>> Attachments: AggregatingResourceLoader-patch-on-547038.txt,
>> CachingResourceLoader-patch-on-549615.txt,
>> ProxyResourceLoader-patch-on-518820.txt,
>> ResourceServlet-patch-on-549620.txt,
>> URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt,
>> URLUtils.java
>>
>>
>> When running a Trinidad application, trinidad-impl.jar is getting locked
>> with open FileInputStream objects. When GC occurs, the FileInputStreams
>> are getting cleared, but as new FileInputStreams are opened on each
>> request, the file is eternally locked. Other files are likely getting
>> locked too.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Reopened: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan reopened TRINIDAD-73:
-----------------------------------
Assignee: (was: Adam Winer)
Reopening issue. Please submit a patch.
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598581#action_12598581 ]
Simon Kitching commented on TRINIDAD-73:
----------------------------------------
Apache Commons Digester also struct this issue. Maybe the patch that fixed Digester could be useful to read. See:
http://issues.apache.org/jira/browse/DIGESTER-29
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Thomas Jacob (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595230#action_12595230 ]
Thomas Jacob commented on TRINIDAD-73:
--------------------------------------
... sorry, I forgot the exception try-catch thing.
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Thomas Jacob (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599875#action_12599875 ]
Thomas Jacob commented on TRINIDAD-73:
--------------------------------------
Simon, I believe that Digester addresses a different issue. However, I cannot 100% prove this, because the API says something like "any caching method should be skipped", and the implementation that would use the setting is private. Still, I believe that getLastModified() is not addressed by this, any I cannot find the time to test this approach.
The other way round, what about my fix suggestion? Any comments?
I will try to create a patch for this (which is the first time I try so please forgive any mistakes here).
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620891#action_12620891 ]
Matthias Weßendorf commented on TRINIDAD-73:
--------------------------------------------
added public URLUtils class, made internal @Deprecated.
rest of the fix will show up very soon
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Matthias Weßendorf
> Fix For: 1.0.2-core
>
> Attachments: AggregatingResourceLoader-patch-on-547038.txt, CachingResourceLoader-patch-on-549615.txt, ProxyResourceLoader-patch-on-518820.txt, ResourceServlet-patch-on-549620.txt, URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt, URLUtils.java
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf resolved TRINIDAD-73.
----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.0.2-core)
1.0.10-core
1.2.10-core
thanks to Thomas Jacobs for his patch. Converted to current trunk(s) and committedit
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Matthias Weßendorf
> Fix For: 1.2.10-core, 1.0.10-core
>
> Attachments: AggregatingResourceLoader-patch-on-547038.txt, CachingResourceLoader-patch-on-549615.txt, ProxyResourceLoader-patch-on-518820.txt, ResourceServlet-patch-on-549620.txt, URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt, URLUtils.java
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Thomas Jacob (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595227#action_12595227 ]
Thomas Jacob commented on TRINIDAD-73:
--------------------------------------
Sorry, but the fix does not work. The JARUrlConnection to the entry delegates to a UrlConnection to the entire JAR file, which in turn has the problem described above.
The close() in the fix is performed on the wrong connection.
However, the JAR file UrlConnection is not accessable, but changing the code
URLConnection connection = url.openConnection();
long modified = connection.getLastModified();
try
{
InputStream is = connection.getInputStream();
if (is != null)
is.close();
}
to
URLConnection connection = url.openConnection();
long modified;
if (connection instanceof JarURLConnection) {
JarURLConnection jarUrlConnection = (JarURLConnection) connection;
URL jarFileUrl = jarUrlConnection.getJarFileURL();
URLConnection jarFileConnection = jarFileUrl.openConnection();
lastModified = jarFileConnection.getLastModified();
jarFileConnection.getInputStream().close();
}
else {
lastModified = connection.getLastModified();
}
may work.
See http://www.mail-archive.com/wicket-user@lists.sourceforge.net/msg20937.html as well.
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer resolved TRINIDAD-73.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0.2-core
Fixed. Or, at least, fixed the failures to call close(), and verified that FileInputStream.finalize() now is only running with FileDescriptors whose "handle" is -1, indicating that they've been properly closed.
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Adam Winer
> Fix For: 1.0.2-core
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Harald Kuhn (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625333#action_12625333 ]
Harald Kuhn commented on TRINIDAD-73:
-------------------------------------
Thanks.
This fix reduces the used file handles on first request from about 50 to 2. That's great.
But I want to share two points I have noticed:
1) this fix seems to be useless if your webapp is deployed to Tomcat (Version 5.5.25) with option antiJARLocking="true".
This might be a Tomcat issue.
2) There are still multiple file handles for the generated css files
(Output of lsof)
java 30914 tomcat 4r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 15r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 43r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 54r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 58r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 61r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 86r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 88r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
java 30914 tomcat 97r REG 8,2 90191 833043 /opt/apache-tomcat-5.5.25/work/Catalina/localhost/current/adf/styles/cache/airplus-desktop-uhtlx2-en-ltr-ie-6.0.css
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Matthias Weßendorf
> Fix For: 1.2.10-core, 1.0.10-core
>
> Attachments: AggregatingResourceLoader-patch-on-547038.txt, CachingResourceLoader-patch-on-549615.txt, ProxyResourceLoader-patch-on-518820.txt, ResourceServlet-patch-on-549620.txt, URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt, URLUtils.java
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507030 ]
Adam Winer commented on TRINIDAD-73:
------------------------------------
It appears that URLConnection.getLastModified() is the culprit - when pointing at a jar: or file: URL, it opens an input stream but does not close it. getInputStream().close() works around this limitation of URLConnection.
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Assignee: Adam Winer
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-73) trinidad-impl.jar file is left open
during execution
Posted by "Thomas Jacob (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600099#action_12600099 ]
Thomas Jacob commented on TRINIDAD-73:
--------------------------------------
... I have set a breakpoint in the errorneous JDK method, and unfortunatelly, the method is still getting called. Now by MyFaces... I fear the story continues...
> trinidad-impl.jar file is left open during execution
> ----------------------------------------------------
>
> Key: TRINIDAD-73
> URL: https://issues.apache.org/jira/browse/TRINIDAD-73
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.1-core
> Reporter: Adam Winer
> Fix For: 1.0.2-core
>
> Attachments: AggregatingResourceLoader-patch-on-547038.txt, CachingResourceLoader-patch-on-549615.txt, ProxyResourceLoader-patch-on-518820.txt, ResourceServlet-patch-on-549620.txt, URLInputStreamProvider-patch-on-549615.txt, URLUtils-patch-on-660215.txt, URLUtils.java
>
>
> When running a Trinidad application, trinidad-impl.jar is getting locked with open FileInputStream objects. When GC occurs, the FileInputStreams are getting cleared, but as new FileInputStreams are opened on each request, the file is eternally locked. Other files are likely getting locked too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.