You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/21 14:42:41 UTC
[GitHub] [spark] cloud-fan opened a new pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
cloud-fan opened a new pull request #34974:
URL: https://github.com/apache/spark/pull/34974
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In https://github.com/apache/spark/pull/32816 , we moved the rule `OptimizeSkewedJoin` from `queryStageOptimizerRules` to `queryStagePreparationRules`. This means that the input plan of `OptimizeSkewedJoin` will be the entire query plan, while before the input plan was a shuffle stage which is usually a small part of the query plan.
However, to simplify the implementation, `OptimizeSkewedJoin` has a check that it will be skipped if the input plan has more than 2 shuffle stages. This is obviously problematic now, as the input plan is the entire query plan and is very likely to have more than 2 shuffles.
This PR proposes to remove the check from `OptimizeSkewedJoin` completely, as it's no longer needed.
1. We can and should optimize all the skewed joins in the query plan.
2. If it introduces extra shuffles, we can return the original input plan, or accept it if the force-apply config is true.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix a performance regression in the master branch (not released yet)
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
a new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998871472
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998838967
**[Test build #146441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146441/testReport)** for PR 34974 at commit [`844077f`](https://github.com/apache/spark/commit/844077fdaa8ce6dd9d56a014bd268ea45cc15be2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-999041639
**[Test build #146441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146441/testReport)** for PR 34974 at commit [`844077f`](https://github.com/apache/spark/commit/844077fdaa8ce6dd9d56a014bd268ea45cc15be2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34974:
URL: https://github.com/apache/spark/pull/34974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998835481
cc @zhengruifeng @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-999048323
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146441/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998838967
**[Test build #146441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146441/testReport)** for PR 34974 at commit [`844077f`](https://github.com/apache/spark/commit/844077fdaa8ce6dd9d56a014bd268ea45cc15be2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-999399343
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998932525
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998917883
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-998932525
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34974: [SPARK-37328][SQL] OptimizeSkewedJoin should work for complex queries with multiple joins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34974:
URL: https://github.com/apache/spark/pull/34974#issuecomment-999048323
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146441/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org