You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/22 04:38:37 UTC

[GitHub] [incubator-nuttx] btashton commented on pull request #2574: libs/libc/dumpbuffer: dump buffer enhancement

btashton commented on pull request #2574:
URL: https://github.com/apache/incubator-nuttx/pull/2574#issuecomment-749333515


   @anchao since this buffer dumping is used on some of the small targets for debugging I am a little worried about what this does to the code size.  Do you think we can keep `lib_dumpbuffer` minimal?
   
   It also seemed like a strange API contract that giving a fd of -1 would call syslog, I see why you did that, but I think it might be best to not to expose that, even if that is in in an internal static function.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org