[GitHub] [druid] clintropolis commented on a change in pull request #11039: improve bitmap vector offset to report contiguous groups

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11039:
URL: https://github.com/apache/druid/pull/11039#discussion_r610297246



##########
File path: processing/src/main/java/org/apache/druid/segment/vector/BitmapVectorOffset.java
##########
@@ -85,6 +87,14 @@ public void advance()
 
       currentVectorSize = to;
     }
+
+    if (currentVectorSize > 1) {

Review comment:
       we could, and I considered it, but ultimately I decided that 1 didn't really "feel" like it met the threshold for me to consider it really contiguous. I also figured it didn't really make a lot of difference between which read method it would end up in because there is only 1 offset either way. But I don't have strong opinions on it though since either seems valid, do you think it logically should be considered contiguous? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org