[GitHub] [iceberg] samarthjain commented on a diff in pull request #6550: Spark 3.3: Automatically set Arrow properties for read performance

[GitBox <gi...@apache.org>]

samarthjain commented on code in PR #6550:
URL: https://github.com/apache/iceberg/pull/6550#discussion_r1065156577


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java:
##########
@@ -75,6 +108,57 @@ public static ColumnarBatchReader buildReader(
                 deleteFilter));
   }
 
+  public static ColumnarBatchReader buildReader(

Review Comment:
   LGTM. 
   
   In our internal Spark fork, we have the arrow config settings configured in the executor JVM args. I can confirm that things have been running fine with them in our prod env for the last 2+ years. So, +1. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org