You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/05 00:18:06 UTC
Review Request 24269: Made ephemeral ports a resource and killed private
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1654
https://issues.apache.org/jira/browse/MESOS-1654
Repository: mesos-git
Description
-------
See summary and ticket for details.
Diffs
-----
include/mesos/mesos.proto 6d4fd14
include/mesos/resources.hpp daaa6bf
src/common/resources.cpp ade2a71
src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
src/slave/flags.hpp 146c401
src/slave/slave.cpp 8e40c5b
src/tests/mesos.cpp 35c94fa
src/tests/port_mapping_tests.cpp 393b578
Diff: https://reviews.apache.org/r/24269/diff/
Testing
-------
make check
sudo make check
Thanks,
Jie Yu
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 5, 2014, 12:45 a.m., Ben Mahler wrote:
> > include/mesos/mesos.proto, lines 295-297
> > <https://reviews.apache.org/r/24269/diff/1/?file=651223#file651223line295>
> >
> > Since this was never released, and it's a repeated field, we should be able to remove it. How about commenting it out so that we don't re-use '9'?
I'll just remove it from the proto file. Since this was never released, re-using '9' is OK, right?
> On Aug. 5, 2014, 12:45 a.m., Ben Mahler wrote:
> > include/mesos/resources.hpp, line 194
> > <https://reviews.apache.org/r/24269/diff/1/?file=651224#file651224line194>
> >
> > Did you want a TODO for an EphemeralPorts abstraction that holds the allocation logic?
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49539
-----------------------------------------------------------
On Aug. 4, 2014, 10:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 10:18 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket for details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6d4fd14
> include/mesos/resources.hpp daaa6bf
> src/common/resources.cpp ade2a71
> src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
> src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
> src/slave/flags.hpp 146c401
> src/slave/slave.cpp 8e40c5b
> src/tests/mesos.cpp 35c94fa
> src/tests/port_mapping_tests.cpp 393b578
>
> Diff: https://reviews.apache.org/r/24269/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49539
-----------------------------------------------------------
Ship it!
A follow up to filter 'ephemeral_ports' from offers for this short term fix SGTM, we probably want to avoid letting frameworks see these since they are ignored by the slave.
include/mesos/mesos.proto
<https://reviews.apache.org/r/24269/#comment86648>
Since this was never released, and it's a repeated field, we should be able to remove it. How about commenting it out so that we don't re-use '9'?
include/mesos/resources.hpp
<https://reviews.apache.org/r/24269/#comment86650>
Did you want a TODO for an EphemeralPorts abstraction that holds the allocation logic?
- Ben Mahler
On Aug. 4, 2014, 10:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 10:18 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket for details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6d4fd14
> include/mesos/resources.hpp daaa6bf
> src/common/resources.cpp ade2a71
> src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
> src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
> src/slave/flags.hpp 146c401
> src/slave/slave.cpp 8e40c5b
> src/tests/mesos.cpp 35c94fa
> src/tests/port_mapping_tests.cpp 393b578
>
> Diff: https://reviews.apache.org/r/24269/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 4, 2014, 10:43 p.m., Dominic Hamon wrote:
> > src/common/resources.cpp, line 520
> > <https://reviews.apache.org/r/24269/diff/1/?file=651225#file651225line520>
> >
> > are you going to expose this in the webui? :)
Nope, not at this time since we try to hide it from frameworks anyway.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49524
-----------------------------------------------------------
On Aug. 5, 2014, 5:11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 5:11 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket for details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6d4fd14
> include/mesos/resources.hpp daaa6bf
> src/common/resources.cpp ade2a71
> src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
> src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
> src/slave/flags.hpp 146c401
> src/slave/slave.cpp 8e40c5b
> src/tests/mesos.cpp 35c94fa
> src/tests/port_mapping_tests.cpp 393b578
>
> Diff: https://reviews.apache.org/r/24269/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49524
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/24269/#comment86628>
are you going to expose this in the webui? :)
- Dominic Hamon
On Aug. 4, 2014, 3:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 3:18 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket for details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6d4fd14
> include/mesos/resources.hpp daaa6bf
> src/common/resources.cpp ade2a71
> src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
> src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
> src/slave/flags.hpp 146c401
> src/slave/slave.cpp 8e40c5b
> src/tests/mesos.cpp 35c94fa
> src/tests/port_mapping_tests.cpp 393b578
>
> Diff: https://reviews.apache.org/r/24269/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49697
-----------------------------------------------------------
Bad patch!
Reviews applied: [24269]
Failed command: git apply --index 24269.patch
Error:
error: patch failed: src/slave/flags.hpp:333
error: src/slave/flags.hpp: patch does not apply
- Mesos ReviewBot
On Aug. 5, 2014, 5:11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 5:11 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket for details.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6d4fd14
> include/mesos/resources.hpp daaa6bf
> src/common/resources.cpp ade2a71
> src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
> src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
> src/slave/flags.hpp 146c401
> src/slave/slave.cpp 8e40c5b
> src/tests/mesos.cpp 35c94fa
> src/tests/port_mapping_tests.cpp 393b578
>
> Diff: https://reviews.apache.org/r/24269/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24269: Made ephemeral ports a resource and killed private
resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 5:11 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-1654
https://issues.apache.org/jira/browse/MESOS-1654
Repository: mesos-git
Description
-------
See summary and ticket for details.
Diffs (updated)
-----
include/mesos/mesos.proto 6d4fd14
include/mesos/resources.hpp daaa6bf
src/common/resources.cpp ade2a71
src/slave/containerizer/isolators/network/port_mapping.hpp f75429c
src/slave/containerizer/isolators/network/port_mapping.cpp 8445874
src/slave/flags.hpp 146c401
src/slave/slave.cpp 8e40c5b
src/tests/mesos.cpp 35c94fa
src/tests/port_mapping_tests.cpp 393b578
Diff: https://reviews.apache.org/r/24269/diff/
Testing
-------
make check
sudo make check
Thanks,
Jie Yu