You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/02 03:14:25 UTC
[GitHub] [shenyu-helm-chart] JooKS-me commented on a diff in pull request #27: [TASk] add shenyu-admin ingress and hpa
JooKS-me commented on code in PR #27:
URL: https://github.com/apache/shenyu-helm-chart/pull/27#discussion_r1037749742
##########
charts/shenyu/values.yaml:
##########
@@ -8,35 +8,62 @@ admin:
# replicas of admin, K8s will load balance the requests
replicas: 1
image: apache/shenyu-admin
- # if you want to change "admin service port", please edit here
- nodePort: 31095
+ service:
+ port: 9095
+ targetPod: 9095
+ # if you want to change "admin service port", please edit here
+ nodePort: 31095
# jvm options for admin
javaOpts: ""
# K8s resources quota for admin
resources:
-# requests:
-# cpu: 100m
-# memory: 512Mi
-# limits:
-# cpu: 1000m
-# memory: 1024Mi
+ # requests:
+ # cpu: 100m
+ # memory: 512Mi
+ # limits:
+ # cpu: 1000m
+ # memory: 1024Mi
+ autoscaling:
+ enabled: true
+ minReplicas: 1
+ maxReplicas: 10
+ targetCPUUtilizationPercentage: 75
+ targetMemoryUtilizationPercentage: 75
+ ingress:
+ enabled: ture
Review Comment:
Let's change it to false by default
##########
charts/shenyu/values.yaml:
##########
@@ -8,35 +8,62 @@ admin:
# replicas of admin, K8s will load balance the requests
replicas: 1
image: apache/shenyu-admin
- # if you want to change "admin service port", please edit here
- nodePort: 31095
+ service:
+ port: 9095
+ targetPod: 9095
+ # if you want to change "admin service port", please edit here
+ nodePort: 31095
# jvm options for admin
javaOpts: ""
# K8s resources quota for admin
resources:
-# requests:
-# cpu: 100m
-# memory: 512Mi
-# limits:
-# cpu: 1000m
-# memory: 1024Mi
+ # requests:
+ # cpu: 100m
+ # memory: 512Mi
+ # limits:
+ # cpu: 1000m
+ # memory: 1024Mi
+ autoscaling:
+ enabled: true
Review Comment:
Let's change it to false by `default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org