You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "sunrioa (via GitHub)" <gi...@apache.org> on 2026/10/14 03:26:09 UTC
[I] feat(workhub): show provider icons consistently with regular conversations [maka]
sunrioa opened a new issue, #6095:
URL: https://github.com/apache/maka/issues/6095
## Problem
The Desktop model menu shows provider icons in regular conversations, but omits them in docked and expanded WorkHub. The same configured models therefore lose a familiar visual identifier when moving between these surfaces.
Source inspection at `main@f61091963` confirms the remaining difference: [regular chat supplies `renderProviderMark`](https://github.com/apache/maka/blob/f61091963b999ff75cd25b62b819833ad4942d8b/apps/desktop/src/renderer/app-shell.tsx#L1403), while [WorkHub does not supply it to the shared Composer](https://github.com/apache/maka/blob/f61091963b999ff75cd25b62b819833ad4942d8b/apps/desktop/src/renderer/features/workhub/ui/workhub-root.tsx#L326).
This remains after #5789 introduced the shared model/effort menu for open native Sessions and expanded WorkHub.
## Desired outcome
Show the same provider icons for the same model choices in regular conversations and docked/expanded WorkHub, while retaining model names, connection identity, selection feedback, and existing model-switching behavior.
The compact WorkHub wheel can remain as designed in #5444. This request concerns provider-icon consistency, not replacing every picker.
## Alternatives or workarounds
Identify models by their names and connection labels alone. This works, but removes the visual cues available in regular conversations.
AI assistance: OpenAI Codex assisted with source inspection and drafting this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] feat(workhub): show provider icons consistently with regular conversations [maka]
Posted by "ggbdpq (via GitHub)" <gi...@apache.org>.
ggbdpq commented on issue #6095:
URL: https://github.com/apache/maka/issues/6095#issuecomment-6415735708
Merged upstream/main (da614305c) to clear the CONFLICTING state. The only conflict was `renderer-architecture.json`: both sides had re-counted `app-shell.tsx` after their own changes, so the ledger was resolved to the values the guard recomputes on the merged tree (importDeclarations 32, importSpecifiers 41, nonTriviaTokens 7271) and the architecture check passes against a4b5f86c5 -- the ProviderBrandMark edge stays reported-not-ratcheted as before. Renderer typecheck is clean on the merge result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] feat(workhub): show provider icons consistently with regular conversations [maka]
Posted by "ggbdpq (via GitHub)" <gi...@apache.org>.
ggbdpq commented on issue #6095:
URL: https://github.com/apache/maka/issues/6095#issuecomment-6163154008
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org