You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/10/27 05:23:40 UTC

svn commit: r1813470 - in /jmeter/trunk: bin/testfiles/OS_TESTS.jmx xdocs/changes.xml

Author: pmouawad
Date: Fri Oct 27 05:23:40 2017
New Revision: 1813470

URL: http://svn.apache.org/viewvc?rev=1813470&view=rev
Log:
Bug 61651 Improve OS test coverage
This closes #318
Bugzilla Id: 61651

Modified:
    jmeter/trunk/bin/testfiles/OS_TESTS.jmx
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/bin/testfiles/OS_TESTS.jmx
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/OS_TESTS.jmx?rev=1813470&r1=1813469&r2=1813470&view=diff
==============================================================================
--- jmeter/trunk/bin/testfiles/OS_TESTS.jmx (original)
+++ jmeter/trunk/bin/testfiles/OS_TESTS.jmx Fri Oct 27 05:23:40 2017
@@ -163,11 +163,21 @@
           <SystemSampler guiclass="SystemSamplerGui" testclass="SystemSampler" testname="OSPS-listDirectory" enabled="true">
             <boolProp name="SystemSampler.checkReturnCode">true</boolProp>
             <stringProp name="SystemSampler.expectedReturnCode">0</stringProp>
-            <stringProp name="SystemSampler.command">dir</stringProp>
+            <stringProp name="SystemSampler.command">cmd</stringProp>
             <elementProp name="SystemSampler.arguments" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
               <collectionProp name="Arguments.arguments">
                 <elementProp name="" elementType="Argument">
                   <stringProp name="Argument.name"></stringProp>
+                  <stringProp name="Argument.value">/C</stringProp>
+                  <stringProp name="Argument.metadata">=</stringProp>
+                </elementProp>
+                <elementProp name="" elementType="Argument">
+                  <stringProp name="Argument.name"></stringProp>
+                  <stringProp name="Argument.value">dir</stringProp>
+                  <stringProp name="Argument.metadata">=</stringProp>
+                </elementProp>
+                <elementProp name="" elementType="Argument">
+                  <stringProp name="Argument.name"></stringProp>
                   <stringProp name="Argument.value">${__groovy(org.apache.jmeter.util.JMeterUtils.getJMeterHome(),)}</stringProp>
                   <stringProp name="Argument.metadata">=</stringProp>
                 </elementProp>
@@ -207,9 +217,20 @@
           <SystemSampler guiclass="SystemSamplerGui" testclass="SystemSampler" testname="OSPS-listEnv" enabled="true">
             <boolProp name="SystemSampler.checkReturnCode">true</boolProp>
             <stringProp name="SystemSampler.expectedReturnCode">0</stringProp>
-            <stringProp name="SystemSampler.command">set</stringProp>
+            <stringProp name="SystemSampler.command">cmd</stringProp>
             <elementProp name="SystemSampler.arguments" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
-              <collectionProp name="Arguments.arguments"/>
+              <collectionProp name="Arguments.arguments">
+                <elementProp name="" elementType="Argument">
+                  <stringProp name="Argument.name"></stringProp>
+                  <stringProp name="Argument.value">/C</stringProp>
+                  <stringProp name="Argument.metadata">=</stringProp>
+                </elementProp>
+                <elementProp name="" elementType="Argument">
+                  <stringProp name="Argument.name"></stringProp>
+                  <stringProp name="Argument.value">set</stringProp>
+                  <stringProp name="Argument.metadata">=</stringProp>
+                </elementProp>
+              </collectionProp>
             </elementProp>
             <elementProp name="SystemSampler.environment" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
               <collectionProp name="Arguments.arguments">
@@ -254,16 +275,6 @@
                   <stringProp name="Argument.value">4</stringProp>
                   <stringProp name="Argument.metadata">=</stringProp>
                 </elementProp>
-                <elementProp name="" elementType="Argument">
-                  <stringProp name="Argument.name"></stringProp>
-                  <stringProp name="Argument.value">&gt;</stringProp>
-                  <stringProp name="Argument.metadata">=</stringProp>
-                </elementProp>
-                <elementProp name="" elementType="Argument">
-                  <stringProp name="Argument.name"></stringProp>
-                  <stringProp name="Argument.value">nul</stringProp>
-                  <stringProp name="Argument.metadata">=</stringProp>
-                </elementProp>
               </collectionProp>
             </elementProp>
             <elementProp name="SystemSampler.environment" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
@@ -277,13 +288,14 @@
             </elementProp>
             <stringProp name="SystemSampler.directory"></stringProp>
             <longProp name="SystemSampler.timeout">1000</longProp>
+            <stringProp name="SystemSampler.stdout">NUL</stringProp>
           </SystemSampler>
           <hashTree>
             <ResponseAssertion guiclass="AssertionGui" testclass="ResponseAssertion" testname="Response Assertion" enabled="true">
               <collectionProp name="Asserion.test_strings">
                 <stringProp name="-57279347">Process timeout out after 1000 milliseconds</stringProp>
               </collectionProp>
-              <stringProp name="Assertion.test_field">Assertion.response_headers</stringProp>
+              <stringProp name="Assertion.test_field">Assertion.response_message</stringProp>
               <boolProp name="Assertion.assume_success">true</boolProp>
               <intProp name="Assertion.test_type">16</intProp>
             </ResponseAssertion>

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1813470&r1=1813469&r2=1813470&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Fri Oct 27 05:23:40 2017
@@ -146,6 +146,7 @@ Summary
     <li><bug>61642</bug>Improve FTP test coverage</li>
     <li><bug>61641</bug>Improve JMS test coverage</li>
     <li><bug>61651</bug>Improve TCP test coverage</li>
+    <li><bug>61651</bug>Improve OS test coverage. Partly contributed by Aleksei Balan (abalanonline at gmail.com)</li> 
 </ul>
 
  <!-- =================== Bug fixes =================== -->
@@ -205,6 +206,7 @@ Summary
     <li><a href="http://ubikloadpack.com">Ubik Load Pack</a></li>
     <li>Justin McCartney (be_strew at yahoo.co.uk)</li>
     <li>Vincent Herilier (https://github.com/vherilier)</li>
+    <li>Aleksei Balan (abalanonline at gmail.com)</li>
 </ul>
 <p>We also thank bug reporters who helped us improve JMeter. <br/>
 For this release we want to give special thanks to the following reporters for the clear reports and tests made after our fixes:</p>