You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/10 00:05:50 UTC
[GitHub] [incubator-superset] khtruong opened a new pull request #8799:
Update sql validator status
khtruong opened a new pull request #8799: Update sql validator status
URL: https://github.com/apache/incubator-superset/pull/8799
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The Presto SQL validator does not always return a message and error location. Sometimes we only get a message. If it is an explicit message from the validator, return it and set its error location as the beginning of the string. Otherwise, return it as a general error as a 400 if the message explicitly says it is a 4xx error.
### TEST PLAN
Tested manually
### REVIEWERS
@betodealmeida @DiggidyDave
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org