You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "xanderbailey (via GitHub)" <gi...@apache.org> on 2026/08/24 08:42:03 UTC
[PR] fix(scan) case sensitive column resolution [iceberg-rust]
xanderbailey opened a new pull request, #3059:
URL: https://github.com/apache/iceberg-rust/pull/3059
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
Wire in case-insensitive flag to the scan for binding filter predicates and checking column names.
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
Yes. Two tests added
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## AI Disclosure
<!--
https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(scan) case sensitive column resolution [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk merged PR #3059:
URL: https://github.com/apache/iceberg-rust/pull/3059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(scan) case sensitive column resolution [iceberg-rust]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey commented on code in PR #3059:
URL: https://github.com/apache/iceberg-rust/pull/3059#discussion_r3841892906
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -223,22 +234,6 @@ impl<'a> TableScanBuilder<'a> {
let schema = snapshot.schema(self.table.metadata())?;
- // Check that all column names exist in the schema (skip reserved columns).
- if let Some(column_names) = self.column_names.as_ref() {
- for column_name in column_names {
- // Skip reserved columns that don't exist in the schema
- if is_metadata_column_name(column_name) {
- continue;
- }
- if schema.field_by_name(column_name).is_none() {
- return Err(Error::new(
- ErrorKind::DataInvalid,
- format!("Column {column_name} not found in table. Schema: {schema}"),
- ));
- }
- }
- }
Review Comment:
My reading is that this was duplicative of the test below so it can be removed altogether. https://github.com/apache/iceberg-rust/pull/3059/changes#diff-0418b823cf97830b1ccd3a3795e670b6e8f9aaf5e37f9093af96714e72dd8ac1R247-R252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org