[GitHub] [beam] rohdesamuel commented on a change in pull request #15118: [BEAM-11666] flake on RecordingManagerTest

[GitBox <gi...@apache.org>]

rohdesamuel commented on a change in pull request #15118:
URL: https://github.com/apache/beam/pull/15118#discussion_r679484895



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py
##########
@@ -463,14 +478,16 @@ def test_clear(self):
     recording.wait_until_finish()
 
     # Assert that clearing only one recording clears that recording.
-    self.assertGreater(rm_1.describe()['size'], 0)
-    self.assertGreater(rm_2.describe()['size'], 0)
-    rm_1.clear()
-    self.assertEqual(rm_1.describe()['size'], 0)
-    self.assertGreater(rm_2.describe()['size'], 0)
-
-    rm_2.clear()
-    self.assertEqual(rm_2.describe()['size'], 0)
+    if rm_1.describe()['state'] != PipelineState.STOPPED \
+            and rm_2.describe()['state'] != PipelineState.STOPPED:

Review comment:
       The terminal state in the recording should be STOPPED, meaning that this case won't be called. Was there a case that this didn't happen?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org