[GitHub] spark pull request: [SPARK-11265] [YARN] [WIP] YarnClient can't ge...

[steveloughran <gi...@git.apache.org>]

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9232#discussion_r42944947
  
    --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala ---
    @@ -245,4 +247,28 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite with Matchers with Logging
           System.clearProperty("SPARK_YARN_MODE")
         }
       }
    +
    +  test("Obtain tokens For HiveMetastore") {
    +    val hadoopConf = new Configuration()
    +    hadoopConf.set("hive.metastore.kerberos.principal", "bob")
    +    // thrift picks up on port 0 and bails out, without trying to talk to endpoint
    +    hadoopConf.set("hive.metastore.uris", "http://localhost:0")
    +    val util = new YarnSparkHadoopUtil
    +    val e = intercept[InvocationTargetException] {
    +      val token = util.obtainTokenForHiveMetastoreInner(hadoopConf, "alice")
    +      fail(s"Expected an exception, got the token $token")
    --- End diff --
    
    wanted to include any token returned in the assert failure, on the basis that if something came back, it would be useful to find out what went wrong. `intercept`, just like JUnit's `@Test(expected=)` feature, picks up on the failure to raise the specific exception, but doesn't appear to say much else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org