You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Christoph Kiehl (JIRA)" <ji...@apache.org> on 2007/06/28 18:14:26 UTC

[jira] Created: (JCR-992) Improve Performance of DescendantSelfAxisQuery

Improve Performance of DescendantSelfAxisQuery
----------------------------------------------

                 Key: JCR-992
                 URL: https://issues.apache.org/jira/browse/JCR-992
             Project: Jackrabbit
          Issue Type: Improvement
          Components: query
    Affects Versions: 1.3
            Reporter: Christoph Kiehl
            Priority: Minor


In DescendantSelfAxisQuery.DescendantSelfAxisScorer.isValid(int) contextHits is populated with docs that are found on the way down the axis. The current algorithm unfortunately doesn't add any new docs at all because it only adds docs already present in contextHits. This leads to more calls to HierarchyResolver.getParent(int) than necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-992) Improve Performance of DescendantSelfAxisQuery

Posted by "Christoph Kiehl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christoph Kiehl updated JCR-992:
--------------------------------

    Attachment: DescendantSelfAxisQuery.patch

This patch adds logic to add all docs on the way down the axis to contextHits if the given doc is a child of the context.

> Improve Performance of DescendantSelfAxisQuery
> ----------------------------------------------
>
>                 Key: JCR-992
>                 URL: https://issues.apache.org/jira/browse/JCR-992
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>    Affects Versions: 1.3
>            Reporter: Christoph Kiehl
>            Priority: Minor
>         Attachments: DescendantSelfAxisQuery.patch
>
>
> In DescendantSelfAxisQuery.DescendantSelfAxisScorer.isValid(int) contextHits is populated with docs that are found on the way down the axis. The current algorithm unfortunately doesn't add any new docs at all because it only adds docs already present in contextHits. This leads to more calls to HierarchyResolver.getParent(int) than necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-992) Improve Performance of DescendantSelfAxisQuery

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-992:
------------------------------

          Component/s: jackrabbit-core
    Affects Version/s:     (was: 1.3)

> Improve Performance of DescendantSelfAxisQuery
> ----------------------------------------------
>
>                 Key: JCR-992
>                 URL: https://issues.apache.org/jira/browse/JCR-992
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, query
>            Reporter: Christoph Kiehl
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: DescendantSelfAxisQuery.patch
>
>
> In DescendantSelfAxisQuery.DescendantSelfAxisScorer.isValid(int) contextHits is populated with docs that are found on the way down the axis. The current algorithm unfortunately doesn't add any new docs at all because it only adds docs already present in contextHits. This leads to more calls to HierarchyResolver.getParent(int) than necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-992) Improve Performance of DescendantSelfAxisQuery

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-992.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

Thanks a lot for the patch. Looks good. I only renamed the list from parentDocs to ancestorDocs before I committed the patch.

svn revision: 551890

> Improve Performance of DescendantSelfAxisQuery
> ----------------------------------------------
>
>                 Key: JCR-992
>                 URL: https://issues.apache.org/jira/browse/JCR-992
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>    Affects Versions: 1.3
>            Reporter: Christoph Kiehl
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: DescendantSelfAxisQuery.patch
>
>
> In DescendantSelfAxisQuery.DescendantSelfAxisScorer.isValid(int) contextHits is populated with docs that are found on the way down the axis. The current algorithm unfortunately doesn't add any new docs at all because it only adds docs already present in contextHits. This leads to more calls to HierarchyResolver.getParent(int) than necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.