You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 21:13:00 UTC

[GitHub] [arrow] n3world commented on pull request #10509: ARROW-12996: Add bytes_read() to StreamingReader

n3world commented on pull request #10509:
URL: https://github.com/apache/arrow/pull/10509#issuecomment-861834800


   > Looks good, one minor nit: If there is just one property then `bytes_read` makes sense. So the API is fine. Internally there are two properties `bytes_read_` and `bytes_parsed_` which is a little confusing to me because I immediately thought `bytes_read_` meant "read but not parsed" since the order is "read->parse->decode". Maybe change `bytes_read_` to `bytes_decoded_` but leave it as `bytes_read` at the API level?
   
   I only named the variable bytes_read_ to match the method name so if you are fine with the bytes_read() returning the value of bytes_decoded_, I'll make that change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org