[GitHub] [iceberg] kbendick commented on a diff in pull request #4786: [0.13] Flink upsert delete file metadata backports

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4786:
URL: https://github.com/apache/iceberg/pull/4786#discussion_r874200441


##########
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -103,5 +103,10 @@ protected class RowDataDeltaWriter extends BaseEqualityDeltaWriter {
     protected StructLike asStructLike(RowData data) {
       return wrapper.wrap(data);
     }
+
+    @Override
+    protected StructLike asStructLikeKey(RowData data) {
+      return wrapper.wrap(data);

Review Comment:
   I would keep it this way upon initial inspection.
   
   It needs to be implemented for the API and it will possibly get called. Keeping it the same as `asStructLike` seems safest for backwards compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org