You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Brett Porter <br...@apache.org> on 2009/04/08 16:17:01 UTC

Re: Validation in Ant and Shell projects - CONTINUUM-2083

Your message seemed to be cut short, but before persistence should be  
sufficient. I can't see how the "After" makes any sense - it would  
just match itself?

- Brett

On 31/03/2009, at 12:06 PM, José Morales Martínez wrote:

> Actually, when we add an Ant or Shell project, there is a validation  
> that checks if there is already a project with the same projectname,  
> scmurl and version. Taking into account all projects types (Ant,  
> Maven and Shell).
>
> The bug is because the validation is done before save data and after  
> it. There is attched a patch in which the validation was checked  
> only before persist data, solving this problem, but then come up the  
> question if is it a good validation?.
>
> What should the validation check
>
> NOTE: Validation is related to [CONTINUUM-1445].
>
> http://jira.codehaus.org/browse/CONTINUUM-2083
>
> http://jira.codehaus.org/browse/CONTINUUM-1445
>
> -----------------------
> Jose
>
> ______________________
> Este mensaje, y en su caso, cualquier fichero anexo al mismo,
> puede contener informacion clasificada por su emisor como confidencial
> en el marco de su Sistema de Gestion de Seguridad de la
> Informacion siendo para uso exclusivo del destinatario, quedando
> prohibida su divulgacion copia o distribucion a terceros sin la
> autorizacion expresa del remitente. Si Vd. ha recibido este mensaje
> erroneamente, se ruega lo notifique al remitente y proceda a su  
> borrado.
> Gracias por su colaboracion.
> ______________________
> This message including any attachments may contain confidential
> information, according to our Information Security Management System,
> and intended solely for a specific individual to whom they are  
> addressed.
> Any unauthorised copy, disclosure or distribution of this message
> is strictly forbidden. If you have received this transmission in  
> error,
> please notify the sender immediately and delete it.
> ______________________


RE: Validation in Ant and Shell projects - CONTINUUM-2083

Posted by José Morales Martínez <jm...@gmv.com>.
It is a problem with execAndWait filter(display an image while create the project), validate method and struts. This filter makes to repeat the validation so call several times to validate method (a method that validates the existence of project) and then error is showed but project is created. The validation has been passed to add method to prevent this problem.

-----------------------
Jose



-----Original Message-----
From: Brett Porter [mailto:brett@apache.org]
Sent: mié 08/04/2009 16:17
To: dev@continuum.apache.org
Subject: Re: Validation in Ant and Shell projects - CONTINUUM-2083

Your message seemed to be cut short, but before persistence should be
sufficient. I can't see how the "After" makes any sense - it would
just match itself?

- Brett

______________________
Este mensaje, y en su caso, cualquier fichero anexo al mismo,
 puede contener informacion clasificada por su emisor como confidencial
 en el marco de su Sistema de Gestion de Seguridad de la 
Informacion siendo para uso exclusivo del destinatario, quedando 
prohibida su divulgacion copia o distribucion a terceros sin la 
autorizacion expresa del remitente. Si Vd. ha recibido este mensaje 
 erroneamente, se ruega lo notifique al remitente y proceda a su borrado. 
Gracias por su colaboracion.
______________________
This message including any attachments may contain confidential 
information, according to our Information Security Management System,
 and intended solely for a specific individual to whom they are addressed.
 Any unauthorised copy, disclosure or distribution of this message
 is strictly forbidden. If you have received this transmission in error,
 please notify the sender immediately and delete it.
______________________