You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by re...@apache.org on 2012/05/03 19:11:28 UTC
svn commit: r1333555 - in
/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core:
init/ContentLoader.java util/ImportExport.java
Author: rene
Date: Thu May 3 17:11:27 2012
New Revision: 1333555
URL: http://svn.apache.org/viewvc?rev=1333555&view=rev
Log:
sonar: create final string before performing as SQL statement
Modified:
incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/ContentLoader.java
incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/util/ImportExport.java
Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/ContentLoader.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/ContentLoader.java?rev=1333555&r1=1333554&r2=1333555&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/ContentLoader.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/ContentLoader.java Thu May 3 17:11:27 2012
@@ -65,8 +65,8 @@ public class ContentLoader {
boolean existingData = false;
try {
statement = conn.createStatement(ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_READ_ONLY);
-
- resultSet = statement.executeQuery("SELECT * FROM " + SyncopeConf.class.getSimpleName());
+ final String queryContent = "SELECT * FROM " + SyncopeConf.class.getSimpleName();
+ resultSet = statement.executeQuery(queryContent);
resultSet.last();
existingData = resultSet.getRow() > 0;
@@ -111,7 +111,8 @@ public class ContentLoader {
try {
statement = conn.createStatement();
- statement.executeUpdate(views.get(idx).toString().replaceAll("\\n", " "));
+ final String updateViews = views.get(idx).toString().replaceAll("\\n", " ");
+ statement.executeUpdate(updateViews);
statement.close();
} catch (SQLException e) {
LOG.error("Could not create view ", e);
@@ -135,7 +136,8 @@ public class ContentLoader {
try {
statement = conn.createStatement();
- statement.executeUpdate(indexes.get(idx).toString());
+ final String updateIndexed = indexes.get(idx).toString();
+ statement.executeUpdate(updateIndexed);
statement.close();
} catch (SQLException e) {
LOG.error("Could not create index ", e);
Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/util/ImportExport.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/util/ImportExport.java?rev=1333555&r1=1333554&r2=1333555&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/util/ImportExport.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/util/ImportExport.java Thu May 3 17:11:27 2012
@@ -131,7 +131,8 @@ public class ImportExport extends Defaul
try {
stmt = conn.createStatement();
- rs = stmt.executeQuery("SELECT * FROM " + tableName);
+ final String queryString = "SELECT * FROM " + tableName;
+ rs = stmt.executeQuery(queryString);
for (int i = 0; i < rs.getMetaData().getColumnCount(); i++) {
colTypes.put(rs.getMetaData().getColumnName(i + 1).toUpperCase(), rs.getMetaData().getColumnType(i + 1));
}