You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 13:17:48 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10970:
[FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a
different one in ActionWatcher.await
tillrohrmann commented on a change in pull request #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await
URL: https://github.com/apache/flink/pull/10970#discussion_r373473949
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -313,7 +314,12 @@ public void close() {
flinkConfig.get(KubernetesConfigOptions.SERVICE_CREATE_TIMEOUT));
return CompletableFuture.supplyAsync(() -> {
Review comment:
I think it would be good enough to supply a `SupplierWithException` here via `FunctionUtils.uncheckedSupplier()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services