You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/20 11:10:00 UTC
[jira] [Commented] (FLINK-10943) Flink runtime test failed caused
by curator dependency conflicts
[ https://issues.apache.org/jira/browse/FLINK-10943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693063#comment-16693063 ]
ASF GitHub Bot commented on FLINK-10943:
----------------------------------------
link3280 opened a new pull request #7148: [FLINK-10943][tests] Fix test failures in flink runtime caused by curator dependency conflicts
URL: https://github.com/apache/flink/pull/7148
## What is the purpose of the change
Hadoop-common of 2.6 + version includes curator dependencies, which would have conflicts with the curator used by Flink runtime and cause test failures (the attachment is the surefire report).
The curator dependencies tree of flink runtime is as below:
```
flink-shaded-hadoop2 -> hadoop-common -> curator-client & curator-recipes
flink-shaded-curator -> curator-recipes -> curator-framework -> curator-client
```
According to the dependency mechanism, maven would pick the curator-client in flink-shaded-hadoop2, and curator-framework and curator-recipes from flink-shaded-curator.
This PR fixes the test failures in flink runtime caused by curator dependency conflicts.
## Brief change log
Exclude curator client from the shaded hadoop dependencies in flink-runtime.
## Verifying this change
This change is already covered by existing zookeeper related tests, such as:
- org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest
This test should work with hadoop 2.6.0 or higher version.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Flink runtime test failed caused by curator dependency conflicts
> ----------------------------------------------------------------
>
> Key: FLINK-10943
> URL: https://issues.apache.org/jira/browse/FLINK-10943
> Project: Flink
> Issue Type: Bug
> Components: Build System, Tests
> Affects Versions: 1.5.5, 1.6.2
> Reporter: Paul Lin
> Priority: Minor
> Labels: pull-request-available
> Attachments: org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt
>
>
> Hadoop-common of 2.6 + version includes curator dependencies, which would have conflicts with the curator used by Flink runtime and cause test failures (the attachment is the surefire report).
> The curator dependencies tree of flink runtime is as below:
> ```
> flink-shaded-hadoop2 -> hadoop-common -> curator-client & curator-recipes
> flink-shaded-curator -> curator-recipes -> curator-framework -> curator-client
> ```
> According to the dependency mechanism, maven would pick the curator-client in flink-shaded-hadoop2, and curator-framework and curator-recipes from flink-shaded-curator.
> To fix the problem I think we can simply exclude curator-client from flink-shaded-hadoop2 dependency in flink-runtime.
> I'd like to fix this, please let me know what you think. Thanks!
> [^org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)