You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chao Sun <ch...@cloudera.com> on 2014/11/20 22:43:41 UTC
Review Request 28299: HIVE-8921 - Investigate test failure on
auto_join2.q [Spark Branch]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28299/
-----------------------------------------------------------
Review request for hive, Jimmy Xiang and Szehon Ho.
Bugs: HIVE-8921
https://issues.apache.org/jira/browse/HIVE-8921
Repository: hive-git
Description
-------
Running this test, sometimes it produce the correct result, sometimes it just produce NULL. Looks like there's some concurrency issue.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 96481f1
ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 6fbdcd2
Diff: https://reviews.apache.org/r/28299/diff/
Testing
-------
Thanks,
Chao Sun
Re: Review Request 28299: HIVE-8921 - Investigate test failure on
auto_join2.q [Spark Branch]
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28299/#review62490
-----------------------------------------------------------
Ship it!
Ship It!
- Szehon Ho
On Nov. 21, 2014, 1:28 a.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28299/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 1:28 a.m.)
>
>
> Review request for hive, Jimmy Xiang and Szehon Ho.
>
>
> Bugs: HIVE-8921
> https://issues.apache.org/jira/browse/HIVE-8921
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Running this test, sometimes it produce the correct result, sometimes it just produce NULL. Looks like there's some concurrency issue.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 96481f1
> ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 6fbdcd2
>
> Diff: https://reviews.apache.org/r/28299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chao Sun
>
>
Re: Review Request 28299: HIVE-8921 - Investigate test failure on
auto_join2.q [Spark Branch]
Posted by Chao Sun <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28299/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 1:28 a.m.)
Review request for hive, Jimmy Xiang and Szehon Ho.
Bugs: HIVE-8921
https://issues.apache.org/jira/browse/HIVE-8921
Repository: hive-git
Description
-------
Running this test, sometimes it produce the correct result, sometimes it just produce NULL. Looks like there's some concurrency issue.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 96481f1
ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 6fbdcd2
Diff: https://reviews.apache.org/r/28299/diff/
Testing
-------
Thanks,
Chao Sun
Re: Review Request 28299: HIVE-8921 - Investigate test failure on
auto_join2.q [Spark Branch]
Posted by Chao Sun <ch...@cloudera.com>.
> On Nov. 20, 2014, 9:56 p.m., Jimmy Xiang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java, line 67
> > <https://reviews.apache.org/r/28299/diff/1/?file=771588#file771588line67>
> >
> > Should be other way around, i.e., the default constructor call this one: this(new LinkHashMap...)
OK, will do in this way.
- Chao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28299/#review62437
-----------------------------------------------------------
On Nov. 20, 2014, 9:43 p.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28299/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:43 p.m.)
>
>
> Review request for hive, Jimmy Xiang and Szehon Ho.
>
>
> Bugs: HIVE-8921
> https://issues.apache.org/jira/browse/HIVE-8921
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Running this test, sometimes it produce the correct result, sometimes it just produce NULL. Looks like there's some concurrency issue.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 96481f1
> ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 6fbdcd2
>
> Diff: https://reviews.apache.org/r/28299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chao Sun
>
>
Re: Review Request 28299: HIVE-8921 - Investigate test failure on
auto_join2.q [Spark Branch]
Posted by Jimmy Xiang <jx...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28299/#review62437
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java
<https://reviews.apache.org/r/28299/#comment104481>
Should be other way around, i.e., the default constructor call this one: this(new LinkHashMap...)
- Jimmy Xiang
On Nov. 20, 2014, 9:43 p.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28299/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:43 p.m.)
>
>
> Review request for hive, Jimmy Xiang and Szehon Ho.
>
>
> Bugs: HIVE-8921
> https://issues.apache.org/jira/browse/HIVE-8921
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Running this test, sometimes it produce the correct result, sometimes it just produce NULL. Looks like there's some concurrency issue.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java 96481f1
> ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java 6fbdcd2
>
> Diff: https://reviews.apache.org/r/28299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chao Sun
>
>