You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2015/02/24 20:57:14 UTC

Review Request 31375: HIVE-9730 make sure logging is never called when not needed in perf-sensitive places

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31375/
-----------------------------------------------------------

Review request for hive and Gopal V.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/LogLevels.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ab011fc 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 4778bb6 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 612f927 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f700353 
  ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 8e1e6e2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java caa4528 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1d5ebb1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java 1da8933 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultBucketMatcher.java fccdc89 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java 48ce67a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java b695bef 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java dbd6e60 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 810aaa6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java dfee3a5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 80ce96a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Heartbeater.java 567890a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java f49cb2a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java c6bfd03 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 5c211c7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 5969050 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java c491a47 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java 0e2552b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PartitionKeySampler.java 96f4530 
  ql/src/java/org/apache/hadoop/hive/ql/exec/RCFileMergeOperator.java 37a1de9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java bc91529 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 8d8f49c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 6f6f5fa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1642926 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 9557efd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java cc5fe5e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 2a55527 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java 5501459 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 0fe176b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 04864b9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java d0693ef 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 8c2ba6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 058d63d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java 8d3e3cc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 819fce7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 4814a3b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionEdge.java 6c3ba3a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java f7612d6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java c9029f2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 696874e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java afe83d9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java 56428b1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 89286e5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java fc83a86 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAppMasterEventOperator.java d05cc23 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java bb18b32 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 918c299 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 5201c57 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java 88ec2b2 
  ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 6710c14 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 9d5730d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 62c6f8d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 498ee14 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 2745bee 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java cb7c103 
  ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java f202991 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java 10eefac 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java aca4273 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java d18e1a7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java f6616fb 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java b23baf3 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java 0b10d99 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java 275b064 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyPrimitive.java 32224a8 

Diff: https://reviews.apache.org/r/31375/diff/


Testing
-------


Thanks,

Sergey Shelukhin