You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/22 16:59:40 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4585: Presence vector
Jackie-Jiang commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r337633916
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/data/Schema.java
##########
@@ -226,6 +226,7 @@ public void addField(@Nonnull String columnName, @Nonnull FieldSpec fieldSpec) {
public boolean removeField(String columnName) {
FieldSpec existingFieldSpec = _fieldSpecMap.remove(columnName);
+
Review comment:
(nit) revert this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org