[GitHub] [arrow] westonpace commented on a diff in pull request #15125: GH-28074: [C++][Dataset] Handle NaNs correctly in Parquet predicate push-down

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #15125:
URL: https://github.com/apache/arrow/pull/15125#discussion_r1097473086


##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -306,6 +277,69 @@ Result<bool> IsSupportedParquetFile(const ParquetFileFormat& format,
 
 }  // namespace
 
+std::optional<compute::Expression> ParquetFileFragment::EvaluateStatisticsAsExpression(
+    std::shared_ptr<Field> field, std::shared_ptr<parquet::Statistics> statistics) {

Review Comment:
   ```suggestion
   std::optional<compute::Expression> ParquetFileFragment::EvaluateStatisticsAsExpression(
       const Field& field, const parquet::Statistics& statistics) {
   ```
   
   Minor nit: prefer accepting `const X&` over `std::shared_ptr<X>` or even `const std::shared_ptr<X>&` if you can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org