You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by chanlee514 <gi...@git.apache.org> on 2017/03/09 01:45:50 UTC
[GitHub] incubator-predictionio pull request #357: [PIO-51] Properly locate engine di...
GitHub user chanlee514 opened a pull request:
https://github.com/apache/incubator-predictionio/pull/357
[PIO-51] Properly locate engine directory
When --engine-dir is passed as CLI argument, use this instead of
user.dir
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chanlee514/incubator-predictionio hotfix/engine-dir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit 39ff8ac727723b3926b30bd19506fba2fba5e251
Author: Chan Lee <ch...@gmail.com>
Date: 2017-03-09T01:38:26Z
[PIO-51] Properly locate engine directory
When --engine-dir is passed as CLI argument, use this instead of
user.dir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #357: [PIO-51] Properly locate engine di...
Posted by chanlee514 <gi...@git.apache.org>.
Github user chanlee514 commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/357#discussion_r105086596
--- Diff: tools/src/main/scala/org/apache/predictionio/tools/console/Console.scala ---
@@ -734,7 +734,7 @@ object Console extends Logging {
}
}
- def getEngineInfo(jsonFile: File): EngineInfo = {
+ def getEngineInfo(jsonFile: File, engineDir: Option[String]): EngineInfo = {
--- End diff --
@dszeto Right I'll make the changes. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #357: [PIO-51] Properly locate engine di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #357: [PIO-51] Properly locate engine di...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/357#discussion_r105085253
--- Diff: tools/src/main/scala/org/apache/predictionio/tools/console/Console.scala ---
@@ -734,7 +734,7 @@ object Console extends Logging {
}
}
- def getEngineInfo(jsonFile: File): EngineInfo = {
+ def getEngineInfo(jsonFile: File, engineDir: Option[String]): EngineInfo = {
--- End diff --
@chanlee514 should we just pass in a `String` here? It doesn't look like there would be a case for `None`. It also looks like `o.a.p.tools.Common.getEngineDirPath` has already taken care of getting the current working directory, so I think it should be safe to just drop using `user.dir` completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---