You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/31 03:52:08 UTC
[GitHub] [bookkeeper] liudezhi2098 opened a new pull request #2231: Fix
batch read data in cache does not take effect
liudezhi2098 opened a new pull request #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231
Descriptions of the changes in this PR:
### Motivation
Fix batch read data in cache does not take effect
### Changes
(Describe: what changes you have made)
Master Issue: #<2230>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli merged pull request #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] liudezhi2098 commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-582460502
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] liudezhi2098 commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-570484412
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] jiazhai commented on issue #2231: Fix batch read data
in cache does not take effect
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-571480409
rebuild java11
run integration tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-595636193
@liudezhi2098 can you please merge with master branch so that CI kicks in again ?
We had problems with GitHub actions, hopefully they have been solved
thanks in advance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] liudezhi2098 commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-570129225
HI.
Problems I found while testing pulsar consumption backtrace,
When reading historical data, you need to pull to disk. In theory, it should be batch pull, but from the phenomenon point of view, it does not. It is used in 4.9.2
Set -1 to firstEntryId and let it increment
------------------ 原始邮件 ------------------
发件人: "Enrico Olivelli"<notifications@github.com>;
发送时间: 2019年12月31日(星期二) 下午2:37
收件人: "apache/bookkeeper"<bookkeeper@noreply.github.com>;
抄送: "Just do it "<278903642@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/bookkeeper] Fix batch read data in cache does not take effect (#2231)
Hi.
Can you please explain your problem and the fix?
We should also add a test case to demonstrate that the fix works and in order to prevent regressions in the future.
Thank you for contributing your fix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] sijie commented on issue #2231: Fix batch read data in
cache does not take effect
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-578526698
@eolivelli
I think the code is obvious and the code path should have been already covered by existing tests. So this change should be good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-589537866
I am sorry but the magic comment doesn't work anymore with github actions.
I will trigger CI manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] jiazhai commented on issue #2231: Fix batch read data
in cache does not take effect
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-571963546
@eolivelli is helping fix the CI issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] liudezhi2098 commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-589522785
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2231: Fix batch read
data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-569874343
Hi.
Can you please explain your problem and the fix?
We should also add a test case to demonstrate that the fix works and in order to prevent regressions in the future.
Thank you for contributing your fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] liudezhi2098 removed a comment on issue #2231: Fix
batch read data in cache does not take effect
Posted by GitBox <gi...@apache.org>.
liudezhi2098 removed a comment on issue #2231: Fix batch read data in cache does not take effect
URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-582460502
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services