You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangshenghang (via GitHub)" <gi...@apache.org> on 2026/07/01 14:36:09 UTC
[PR] [Fix][Core] Extend serialVersionUID checker coverage [seatunnel]
zhangshenghang opened a new pull request, #11257:
URL: https://github.com/apache/seatunnel/pull/11257
### Purpose
Fixes #11020.
The existing `SerialVersionUIDCheckerTest` only checked the generic state types referenced by `SeaTunnelSource` and `SeaTunnelSink` implementations. It missed other Java-serialized classes that are part of job graph or restore-related paths, such as CDC source config factories/config objects and engine job graph DTOs.
### Changes
- Extend `SerialVersionUIDCheckerTest` to check:
- CDC connector config/config-factory classes under `connector-cdc`
- engine job graph classes under `engine/core/job` and `engine/common/job`
- existing source/sink generic state types
- Require `serialVersionUID` to be declared on the concrete class itself instead of accepting an inherited field.
- Add explicit `serialVersionUID` fields to the currently uncovered CDC config/factory classes and engine job graph DTOs.
- Preserve the existing MySQL CDC factory UID baseline by declaring `-6578851046816898665L`.
### Verification
- `./mvnw spotless:apply`
- `./mvnw -pl seatunnel-ci-tools -Dtest=SerialVersionUIDCheckerTest test`
- `./mvnw -q -DskipTests verify`
- `./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql -Dtest=MySqlSourceConfigFactorySerializationTest test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Extend serialVersionUID checker coverage [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11257:
URL: https://github.com/apache/seatunnel/pull/11257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Extend serialVersionUID checker coverage [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11257:
URL: https://github.com/apache/seatunnel/pull/11257#issuecomment-4884365024
Thanks for the follow-up. I rechecked the PR metadata before posting again: there is still no new commit after `0e44c74`, so I am not reopening a full review on unchanged code. From my side the blocker I raised earlier has already been addressed on the current head; at this point I do not have a new source-level concern beyond waiting for CI to stay green on the latest base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org