You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/08 06:34:53 UTC

[GitHub] [spark] jiangxb1987 commented on a change in pull request #24530: [SPARK-27520][CORE][WIP] Introduce a global config system to replace hadoopConfiguration

jiangxb1987 commented on a change in pull request #24530: [SPARK-27520][CORE][WIP] Introduce a global config system to replace hadoopConfiguration
URL: https://github.com/apache/spark/pull/24530#discussion_r281929503
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala
 ##########
 @@ -600,8 +600,8 @@ class JavaSparkContext(val sc: SparkContext) extends Closeable {
    * @note As it will be reused in all Hadoop RDDs, it's better not to modify it unless you
    * plan to set some global configurations for all Hadoop RDDs.
    */
-  def hadoopConfiguration(): Configuration = {
-    sc.hadoopConfiguration
+  def getHadoopConf(): Configuration = {
 
 Review comment:
   Also mark this as deprecated instead of remove the function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org