[jira] [Commented] (FLINK-3847) Reorganize package structure of flink-table

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263947#comment-15263947 ] 

ASF GitHub Bot commented on FLINK-3847:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1950

    [FLINK-3847] Restructure flink-table test packages.

    This PR refactors the tests of the flink-table module.
    The new package structure is as follows:
    
    ```
    src/test/java/o/a/f/api/java/batch/sql
                                      /table
                                /stream/sql
                                       /table
                                       /utils
    src/test/scala/o/a/f/api/scala/batch/sql
                                        /table
                                        /utils
                                  /expression
                                  /stream/sql
                                         /table
                                         /utils
                                  /typeutils
    ```
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableTests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1950
    
----
commit 110d335780d15787f535950abdf299a41f06b405
Author: Fabian Hueske <fh...@apache.org>
Date:   2016-04-28T20:51:49Z

    [FLINK-3847] Restructure flink-table test packages.

----


> Reorganize package structure of flink-table
> -------------------------------------------
>
>                 Key: FLINK-3847
>                 URL: https://issues.apache.org/jira/browse/FLINK-3847
>             Project: Flink
>          Issue Type: Task
>          Components: Table API
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>
> The flink-table module has tests for the matrix of 
> - Java and Scala
> - Batch and Streaming
> - Table API and SQL
> Right now, there is no consistent package structure for the tests. I propose to structure the test packages as follows:
> {code}
> test/java/o/a/f/api/table/batch/table
> test/java/o/a/f/api/table/batch/sql
> test/java/o/a/f/api/table/stream/table
> test/java/o/a/f/api/table/stream/sql
> test/scala/o/a/f/api/table/batch/table
> test/scala/o/a/f/api/table/batch/sql
> test/scala/o/a/f/api/table/stream/table
> test/scala/o/a/f/api/table/stream/sql
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)