[GitHub] [incubator-pinot] snleee commented on a change in pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#discussion_r439176537



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -40,6 +40,7 @@
     public static final String LEAD_CONTROLLER_RESOURCE_NAME = "leadControllerResource";
 
     public static final String LEAD_CONTROLLER_RESOURCE_ENABLED_KEY = "RESOURCE_ENABLED";
+    // TODO: Rename this config because it applies to both SQL and PQL
     public static final String ENABLE_CASE_INSENSITIVE_PQL_KEY = "enable.case.insensitive.pql";

Review comment:
       We can add something like `enable.case.sensitivity` and fall back to `enable.case.insensitive.pql`? Since it's a pretty simple change, we can include to this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org