You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/05/11 23:12:44 UTC

[GitHub] [druid] clintropolis commented on a diff in pull request #14262: fix segment metadata queries for auto ingested columns that had all null values

clintropolis commented on code in PR #14262:
URL: https://github.com/apache/druid/pull/14262#discussion_r1191768627


##########
processing/src/test/java/org/apache/druid/segment/TestHelper.java:
##########
@@ -484,6 +484,17 @@ public static Map<String, Object> makeMap(boolean explicitNulls, Object... vals)
     return theVals;
   }
 
+  public static Map<String, Object> makeMapWithExplicitNull(Object... vals)

Review Comment:
   for some reason the test was complaining at me about ambiguous method when trying to use ```makeMap(boolean explicitNulls, Object... vals)``` so i added this version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org