You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@camel.apache.org by bj...@provinzial.de on 2018/11/28 13:08:42 UTC
readLockLoggingLevel File Component
Hi,
one little thing...
I have noticed that in the javadocs, documentations,... for the the
property readLockLoggingLevel in the File Component, respectively in the
class FileChangedExclusiveReadLockStrategy the default is described as
'WARN'. But in the implementation it is 'DEBUG'. It could be helpful to
adjust this...
Best regards
Björn
Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail sind nicht gestattet.
This e-mail may contain confidential and / or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
Re: Re: readLockLoggingLevel File Component
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Thanks for spotting this. I am correcting the docs.
On Thu, Nov 29, 2018 at 9:03 AM <bj...@provinzial.de> wrote:
>
> Yes Zoran,
>
> sometimes I have a great enlightenment;)
> But even small things can slow down your work (if you wonder, why a file
> is not consumed, cause this is only logged at debug)...
>
> Björn
>
>
>
>
> Von: Claus Ibsen <cl...@gmail.com>
> An: users@camel.apache.org
> Datum: 28.11.2018 18:29
> Betreff: Re: readLockLoggingLevel File Component
>
>
>
> Hi
>
> Yeah you are welcome to provide a fix via a github PR
> https://github.com/apache/camel/blob/master/CONTRIBUTING.md
>
> If you are a bit lazy you can even just do the PR by editing the
> source file from the github web ui directly
> On Wed, Nov 28, 2018 at 2:34 PM Zoran Regvart <zo...@regvart.com> wrote:
> >
> > Hi Björn,
> > sounds like a great contribution, we love those :)
> >
> > zoran
> > On Wed, Nov 28, 2018 at 1:19 PM <bj...@provinzial.de> wrote:
> > >
> > > Hi,
> > >
> > > one little thing...
> > > I have noticed that in the javadocs, documentations,... for the the
> > > property readLockLoggingLevel in the File Component, respectively in
> the
> > > class FileChangedExclusiveReadLockStrategy the default is described as
> > > 'WARN'. But in the implementation it is 'DEBUG'. It could be helpful
> to
> > > adjust this...
> > >
> > > Best regards
> > > Björn
> > >
> > >
> > > Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte
> Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder
> diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den
> Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die
> unbefugte Weitergabe dieser Mail sind nicht gestattet.
> > >
> > > This e-mail may contain confidential and / or privileged information.
> If you are not the intended recipient (or have received this e-mail in
> error) please notify the sender immediately and destroy this e-mail. Any
> unauthorised copying, disclosure or distribution of the material in this
> e-mail is strictly forbidden.
> >
> >
> >
> > --
> > Zoran Regvart
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>
>
>
>
> Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail sind nicht gestattet.
>
> This e-mail may contain confidential and / or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Antwort: Re: readLockLoggingLevel File Component
Posted by bj...@provinzial.de.
Yes Zoran,
sometimes I have a great enlightenment;)
But even small things can slow down your work (if you wonder, why a file
is not consumed, cause this is only logged at debug)...
Björn
Von: Claus Ibsen <cl...@gmail.com>
An: users@camel.apache.org
Datum: 28.11.2018 18:29
Betreff: Re: readLockLoggingLevel File Component
Hi
Yeah you are welcome to provide a fix via a github PR
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
If you are a bit lazy you can even just do the PR by editing the
source file from the github web ui directly
On Wed, Nov 28, 2018 at 2:34 PM Zoran Regvart <zo...@regvart.com> wrote:
>
> Hi Björn,
> sounds like a great contribution, we love those :)
>
> zoran
> On Wed, Nov 28, 2018 at 1:19 PM <bj...@provinzial.de> wrote:
> >
> > Hi,
> >
> > one little thing...
> > I have noticed that in the javadocs, documentations,... for the the
> > property readLockLoggingLevel in the File Component, respectively in
the
> > class FileChangedExclusiveReadLockStrategy the default is described as
> > 'WARN'. But in the implementation it is 'DEBUG'. It could be helpful
to
> > adjust this...
> >
> > Best regards
> > Björn
> >
> >
> > Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte
Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die
unbefugte Weitergabe dieser Mail sind nicht gestattet.
> >
> > This e-mail may contain confidential and / or privileged information.
If you are not the intended recipient (or have received this e-mail in
error) please notify the sender immediately and destroy this e-mail. Any
unauthorised copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.
>
>
>
> --
> Zoran Regvart
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail sind nicht gestattet.
This e-mail may contain confidential and / or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
Re: readLockLoggingLevel File Component
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Yeah you are welcome to provide a fix via a github PR
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
If you are a bit lazy you can even just do the PR by editing the
source file from the github web ui directly
On Wed, Nov 28, 2018 at 2:34 PM Zoran Regvart <zo...@regvart.com> wrote:
>
> Hi Björn,
> sounds like a great contribution, we love those :)
>
> zoran
> On Wed, Nov 28, 2018 at 1:19 PM <bj...@provinzial.de> wrote:
> >
> > Hi,
> >
> > one little thing...
> > I have noticed that in the javadocs, documentations,... for the the
> > property readLockLoggingLevel in the File Component, respectively in the
> > class FileChangedExclusiveReadLockStrategy the default is described as
> > 'WARN'. But in the implementation it is 'DEBUG'. It could be helpful to
> > adjust this...
> >
> > Best regards
> > Björn
> >
> >
> > Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail sind nicht gestattet.
> >
> > This e-mail may contain confidential and / or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
>
>
>
> --
> Zoran Regvart
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: readLockLoggingLevel File Component
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Björn,
sounds like a great contribution, we love those :)
zoran
On Wed, Nov 28, 2018 at 1:19 PM <bj...@provinzial.de> wrote:
>
> Hi,
>
> one little thing...
> I have noticed that in the javadocs, documentations,... for the the
> property readLockLoggingLevel in the File Component, respectively in the
> class FileChangedExclusiveReadLockStrategy the default is described as
> 'WARN'. But in the implementation it is 'DEBUG'. It could be helpful to
> adjust this...
>
> Best regards
> Björn
>
>
> Diese E-Mail könnte vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail sind nicht gestattet.
>
> This e-mail may contain confidential and / or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
--
Zoran Regvart