You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/05 09:51:17 UTC

[GitHub] [skywalking] codecov[bot] commented on pull request #6687: Fix `disable` statement not working

codecov[bot] commented on pull request #6687:
URL: https://github.com/apache/skywalking/pull/6687#issuecomment-813311321


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=h1) Report
   > Merging [#6687](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=desc) (1a7094f) into [master](https://codecov.io/gh/apache/skywalking/commit/d7beac5bfc20e35c361c0d771536309241d870e3?el=desc) (d7beac5) will **decrease** coverage by `13.73%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 1a7094f differs from pull request most recent head 2e2083b. Consider uploading reports for the commit 2e2083b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6687/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6687       +/-   ##
   =============================================
   - Coverage     47.25%   33.52%   -13.74%     
   + Complexity     3391     2040     -1351     
   =============================================
     Files          1792      813      -979     
     Lines         38412    20037    -18375     
     Branches       4234     1895     -2339     
   =============================================
   - Hits          18152     6717    -11435     
   + Misses        19265    12833     -6432     
   + Partials        995      487      -508     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.75% <100.00%> (+0.13%)` | `10.00 <0.00> (ø)` | |
   | [...lking/oap/server/core/oal/rt/DisableOALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L0Rpc2FibGVPQUxEZWZpbmUuamF2YQ==) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1384 more](https://codecov.io/gh/apache/skywalking/pull/6687/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=footer). Last update [d7beac5...2e2083b](https://codecov.io/gh/apache/skywalking/pull/6687?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org