You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/24 07:26:46 UTC

[GitHub] [incubator-echarts] 100pah edited a comment on pull request #12172: Fix: Calendar fix for DST

100pah edited a comment on pull request #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-618839295


   @mikeyshing88 Thanks for your carefully check. Sorry I should have made some comment.
   The PR is merged. But then I made little change based on the code located, because it seams not entirely perfect considering the context surrounding the code.
   The code snippet [behind the modified code](https://github.com/apache/incubator-echarts/commit/878829b46c4273b8a6793685b83bcecdb5313f8e#diff-c6ac7d8019f55c5a39e264462a77e161R394) was added before to the resolve another DST issue. But it did not do it correct in some cases we currently found. I modify it to cover this cases. I am not totally sure it is a best way to resolve DST issue in that way. But logically it seams correct to cover all of the cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org