You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/15 17:53:50 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1984: add new error message for customized partition check host connection error
xyuanlu opened a new pull request #1984:
URL: https://github.com/apache/helix/pull/1984
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1983
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Helix user will get "UNHEALTHY_PARTITION:PARTITION_XX" error for customized partition health check failure when
1. There is not enough partition in healthy state, or
2. Helix failed to get partition status from a particular host.
User need to search Helix log to differentiate these two cases. It is hard to debug when there are hundreds of instances in cluster.
This change adds a new error case when Helix gets an empty map for partition status.
### Tests
- [X] The following tests are written for this issue:
TestMaintenanceManagementService.
Existing test changed as behavior changed.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r828515007
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -257,11 +258,16 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
continue;
}
- // We are checking sibling partition healthy status. So if partition health does not
- // exist or it is not healthy. We should mark this partition is unhealthy.
+ // If we failed to get partition assignment for one sibling instance, we add the
+ // nstance name in return error for debugability
Review comment:
typo: instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r830537513
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -55,6 +55,7 @@
ImmutableSet.of(HelixDefinedState.DROPPED.name(), HelixDefinedState.ERROR.name());
static final String UNHEALTHY_PARTITION = "UNHEALTHY_PARTITION";
+ static final String HOST_NO_STATE_ERROR = "HOST_NO_STATE_ERROR:";
Review comment:
Thanks for the suggestion. All the other error messages are the same pattern with ":". I would prefer to keep the current pattern for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r831337823
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -257,11 +258,16 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
continue;
}
- // We are checking sibling partition healthy status. So if partition health does not
- // exist or it is not healthy. We should mark this partition is unhealthy.
+ // If we failed to get partition assignment for one sibling instance, we add the
+ // nstance name in return error for debugability
if (!globalPartitionHealthStatus.containsKey(siblingInstance)
- || !globalPartitionHealthStatus.get(siblingInstance).containsKey(partition)
+ || globalPartitionHealthStatus.get(siblingInstance).isEmpty()) {
+ unhealthyPartitions.computeIfAbsent(partition, list -> new ArrayList<>())
+ .add(HOST_NO_STATE_ERROR + siblingInstance);
+ } else if (!globalPartitionHealthStatus.get(siblingInstance).containsKey(partition)
|| !globalPartitionHealthStatus.get(siblingInstance).get(partition)) {
Review comment:
TFTR. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
junkaixue commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r830425298
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -55,6 +55,7 @@
ImmutableSet.of(HelixDefinedState.DROPPED.name(), HelixDefinedState.ERROR.name());
static final String UNHEALTHY_PARTITION = "UNHEALTHY_PARTITION";
+ static final String HOST_NO_STATE_ERROR = "HOST_NO_STATE_ERROR:";
Review comment:
Is this a prefix thing? For human readable, please have an empty space after ":".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1984:
URL: https://github.com/apache/helix/pull/1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r828551899
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -257,11 +258,16 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
continue;
}
- // We are checking sibling partition healthy status. So if partition health does not
- // exist or it is not healthy. We should mark this partition is unhealthy.
+ // If we failed to get partition assignment for one sibling instance, we add the
+ // nstance name in return error for debugability
Review comment:
typo: debuggability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a change in pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r828516442
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -257,11 +258,16 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
continue;
}
- // We are checking sibling partition healthy status. So if partition health does not
- // exist or it is not healthy. We should mark this partition is unhealthy.
+ // If we failed to get partition assignment for one sibling instance, we add the
+ // nstance name in return error for debugability
if (!globalPartitionHealthStatus.containsKey(siblingInstance)
- || !globalPartitionHealthStatus.get(siblingInstance).containsKey(partition)
+ || globalPartitionHealthStatus.get(siblingInstance).isEmpty()) {
+ unhealthyPartitions.computeIfAbsent(partition, list -> new ArrayList<>())
+ .add(HOST_NO_STATE_ERROR + siblingInstance);
+ } else if (!globalPartitionHealthStatus.get(siblingInstance).containsKey(partition)
|| !globalPartitionHealthStatus.get(siblingInstance).get(partition)) {
Review comment:
could be cleaner with `globalPartitionHealthStatus.get(siblingInstance).getOrDefault()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1984: add new error message for customized partition check host connection error
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1984:
URL: https://github.com/apache/helix/pull/1984#issuecomment-1079399354
This change is ready to be merged. Approved by @junkaixue // Thanks!!
Commit message:
Add new error message for customized partition check host connection error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org