You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "sanskar-thakur (via GitHub)" <gi...@apache.org> on 2023/03/27 17:38:09 UTC
[GitHub] [eventmesh] sanskar-thakur opened a new pull request, #3533: [Enhancement] Method manually handles closing an auto-closeable resource [HTTPClientHandler] #3008
sanskar-thakur opened a new pull request, #3533:
URL: https://github.com/apache/eventmesh/pull/3533
Fixes #3008 .
### Modifications
Replace closing stream in finally block with try-with-resources.
### Documentation
- Does this pull request introduce a new feature? **(no)**
- If yes, how is the feature documented? **(not applicable)**
- If a feature is not applicable for documentation, explain why? **(bug fix)**
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation **(not applicable)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 merged pull request #3533: [Enhancement] Method manually handles closing an auto-closeable resource [HTTPClientHandler] #3008
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3533:
URL: https://github.com/apache/eventmesh/pull/3533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3533: [Enhancement] Method manually handles closing an auto-closeable resource [HTTPClientHandler] #3008
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3533:
URL: https://github.com/apache/eventmesh/pull/3533#issuecomment-1486074603
On line 110 perhaps it could also be changed to use try-with-recourse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org