You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/21 11:02:51 UTC

[GitHub] [shardingsphere] sandynz opened a new issue, #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

sandynz opened a new issue, #20334:
URL: https://github.com/apache/shardingsphere/issues/20334

   Purpose
   - Separate IncrementalDumper from ScalingEntry for better reuse
   
   Possible changes:
   - Add IncrementalDumperCreator interface, extends TypedSPI, marked as @SingletonSPI; Put in the same module and package of AbstractIncrementalDumper;
   - Add MySQL & PostgreSQL & openGauss & Fixture implementations of IncrementalDumperCreator; Register them in resources/WEB-INF.services
   - Add IncrementalDumperCreatorFactory; Put in the same module and package of AbstractIncrementalDumper;
   - Add IncrementalDumperCreatorFactoryTest in shardingsphere-pipeline-test module, assert get instance of IncrementalDumperCreator by type "MySQL" / "PostgreSQL" / "openGauss" / "Fixture";
   - Remove ScalingEntry.getIncrementalDumperClass() method
   - Remove DumperFactory.createIncrementalDumper method and update related code
   - Update related unit test
   - Keep ScalingEntry and related classes & configs for now
   
   Example:
   - InventoryDumperCreator, InventoryDumperCreatorFactory
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huangdx0726 commented on issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20334:
URL: https://github.com/apache/shardingsphere/issues/20334#issuecomment-1221528828

   assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry
URL: https://github.com/apache/shardingsphere/issues/20334


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huangdx0726 commented on issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20334:
URL: https://github.com/apache/shardingsphere/issues/20334#issuecomment-1224033752

   Ok， I'll fix tonight.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20334:
URL: https://github.com/apache/shardingsphere/issues/20334#issuecomment-1221540428

   Thanks. Just assigned it to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #20334: Add IncrementalDumperCreator SPI to decouple IncrementalDumper and ScalingEntry

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20334:
URL: https://github.com/apache/shardingsphere/issues/20334#issuecomment-1223932472

   Hi @huangdx0726 , could we finish this issue in `5.1.3`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org