You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "nvollmar (via GitHub)" <gi...@apache.org> on 2023/05/23 06:13:14 UTC
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar opened a new pull request, #50: Removes Akka references
nvollmar opened a new pull request, #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #50: Removes Akka references
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201691563
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/EventsByTagMigration.scala:
##########
@@ -163,7 +163,7 @@ class EventsByTagMigration(
* Migrates the entire `messages` table to the the new `tag_views` table.
*
* Before running this you must run the migration of the `all_persistence_ids`
- * table as described in https://doc.akka.io/docs/akka-persistence-cassandra/current/migrations.html#all-persistenceIds-query
+ * table as described in https://pekko.apache.org/docs/pekko-persistence-cassandra/current/migrations.html#all-persistenceIds-query
Review Comment:
makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] pjfanning commented on a diff in pull request #50: Removes Akka references
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201696111
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/EventsByTagMigration.scala:
##########
@@ -163,7 +163,7 @@ class EventsByTagMigration(
* Migrates the entire `messages` table to the the new `tag_views` table.
*
* Before running this you must run the migration of the `all_persistence_ids`
- * table as described in https://doc.akka.io/docs/akka-persistence-cassandra/current/migrations.html#all-persistenceIds-query
+ * table as described in https://pekko.apache.org/docs/pekko-persistence-cassandra/current/migrations.html#all-persistenceIds-query
Review Comment:
this comment applies to an old version of akka-persistence-grpc - so another option is to remove this paragraph - the one starting 'Before running this'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #50: Removes Akka references
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201617931
##########
build.sbt:
##########
@@ -92,7 +92,7 @@ lazy val dseTest = project
.settings(libraryDependencies ++= Dependencies.dseTestDependencies)
lazy val docs = project
- .enablePlugins(Common, PekkoParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
Review Comment:
Testing if it's actually used since other projects don't have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] pjfanning commented on a diff in pull request #50: Removes Akka references
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201696111
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/EventsByTagMigration.scala:
##########
@@ -163,7 +163,7 @@ class EventsByTagMigration(
* Migrates the entire `messages` table to the the new `tag_views` table.
*
* Before running this you must run the migration of the `all_persistence_ids`
- * table as described in https://doc.akka.io/docs/akka-persistence-cassandra/current/migrations.html#all-persistenceIds-query
+ * table as described in https://pekko.apache.org/docs/pekko-persistence-cassandra/current/migrations.html#all-persistenceIds-query
Review Comment:
this comment applies to an old version of akka-persistence-cassandra - so another option is to remove this paragraph - the one starting 'Before running this'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar merged pull request #50: Removes Akka references
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar merged PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #50: Removes Akka references
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201618659
##########
build.sbt:
##########
@@ -92,7 +92,7 @@ lazy val dseTest = project
.settings(libraryDependencies ++= Dependencies.dseTestDependencies)
lazy val docs = project
- .enablePlugins(Common, PekkoParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
Review Comment:
Is it okay if we do this in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] pjfanning commented on a diff in pull request #50: Removes Akka references
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201679990
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/EventsByTagMigration.scala:
##########
@@ -163,7 +163,7 @@ class EventsByTagMigration(
* Migrates the entire `messages` table to the the new `tag_views` table.
*
* Before running this you must run the migration of the `all_persistence_ids`
- * table as described in https://doc.akka.io/docs/akka-persistence-cassandra/current/migrations.html#all-persistenceIds-query
+ * table as described in https://pekko.apache.org/docs/pekko-persistence-cassandra/current/migrations.html#all-persistenceIds-query
Review Comment:
this link does not work - could we revert to the working link that we had before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #50: Removes Akka references
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201736172
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/EventsByTagMigration.scala:
##########
@@ -163,7 +163,7 @@ class EventsByTagMigration(
* Migrates the entire `messages` table to the the new `tag_views` table.
*
* Before running this you must run the migration of the `all_persistence_ids`
- * table as described in https://doc.akka.io/docs/akka-persistence-cassandra/current/migrations.html#all-persistenceIds-query
+ * table as described in https://pekko.apache.org/docs/pekko-persistence-cassandra/current/migrations.html#all-persistenceIds-query
Review Comment:
Those migrations are pretty old. Since we’re expecting users to first upgrade to the latest version of akka-persistence-cassandra we could remove those migrations completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #50: Removes Akka references
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/50#discussion_r1201615085
##########
build.sbt:
##########
@@ -92,7 +92,7 @@ lazy val dseTest = project
.settings(libraryDependencies ++= Dependencies.dseTestDependencies)
lazy val docs = project
- .enablePlugins(Common, PekkoParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
Review Comment:
Why is `Common` being removed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org