[GitHub] incubator-rocketmq issue #130: [ROCKETMQ-243] BrokerData#selectBrokerAddr() ...

[Jaskey <gi...@git.apache.org>]

Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/130
  
    Broker contention should be safe but random pick can balance the network call for to all masters.
    
    but we have to be cautions about this since for the current implementations, the broker addr will be very stable since it always return the same broker addr to the caller.
    
    There are more than ten caller methods on this `selectBrokerAddr`, we have to make sure the random pick will not cause any side effect.
    
    I believe it has not @lizhanhui @vongosling @zhouxinyu what's your opions.
    
    @shroman , and since this method only returns the master addrs, I will suggest rename it to `pickMasterAddr`. Since the method is only called by some inner impl caller, I think it is safe to rename.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---