You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/05/11 01:39:35 UTC

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/228

    Fauxton: Fix scrollbar from sidebar on collapsed state in Chrome

    With a collapsed sidebar, in Chrome, the scrollbar was always
    visible, even if the z-index of the dashboard was higher.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb scollbar-chrome

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #228
    
----
commit 5a4ed1f6980c94e6f2fb034c17a30b1830d44b10
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-05-10T18:29:50Z

    Fauxton: Fix scrollbar from sidebar on collapsed state in Chrome
    
    With a collapsed sidebar, in Chrome, the scrollbar was always
    visible, even if the z-index of the dashboard was higher.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb/pull/228#issuecomment-49016932
  
    This looks good. +1 lets merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb/pull/228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/228#issuecomment-49068991
  
    merged as 99665a15ac3a1e56259eb7445b9b2e505ac361fc :) thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/228#issuecomment-46130845
  
    Oh you are right! Should be fixed now.
    
    I made a video: https://cloudup.com/cCF_TE1Yf6E where you can see the issue which happens in Chrome on a Mac for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: Fix scrollbar from sidebar on colla...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb/pull/228#issuecomment-44515452
  
    This seems to push the header to the right. Could you also show an image of what the error was before the fix and after. I'm not 100% sure what is the issue here.
    
    ![screen shot 2014-05-29 at 11 35 14 am](https://cloud.githubusercontent.com/assets/179458/3116166/d42d2bb0-e714-11e3-97f9-c351cc94d0fe.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---