You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/10/23 01:31:36 UTC
[PR] GH-44448: [C++] Add support for overriding grpc_cpp_plugin path for cross-compiling [arrow]
kou opened a new pull request, #44507:
URL: https://github.com/apache/arrow/pull/44507
### Rationale for this change
TODO
### What changes are included in this PR?
TODO
### Are these changes tested?
TODO
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overwriting grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44507:
URL: https://github.com/apache/arrow/pull/44507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overriding grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2430847163
Confirmed in https://github.com/conda-forge/arrow-cpp-feedstock/pull/1432 that this works, even without the `sed` command 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overwriting grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2432429599
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8eccbfe766e26efd9fb63f4acc60b5ab1074a10b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/31954575171) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overwriting grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2430912428
Thanks for confirming this. I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overriding grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2430630052
Thanks a lot for the quick PR!
It would be really nice if we could also change this where it's invoked, i.e.
https://github.com/apache/arrow/blob/5ea3aa1f91710473a619ac96cf9bde782efc5476/cpp/src/arrow/flight/CMakeLists.txt#L95-L98
Currently our builds scripts are doing
```bash
sed -ie "s;protoc-gen-grpc.*$;protoc-gen-grpc=${BUILD_PREFIX}/bin/grpc_cpp_plugin\";g" ../src/arrow/flight/CMakeLists.txt
```
to work around this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overriding grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2430633190
This will work for the case because this overwrites `$<TARGET_FILE:gRPC::grpc_cpp_plugin>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44448: [C++] Add support for overriding grpc_cpp_plugin path for cross-compiling [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44507:
URL: https://github.com/apache/arrow/pull/44507#issuecomment-2430616243
:warning: GitHub issue #44448 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org