You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/20 03:29:11 UTC
[GitHub] [spark] allisonwang-db opened a new pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
allisonwang-db opened a new pull request #30437:
URL: https://github.com/apache/spark/pull/30437
Backport #30373 for branch-2.4.
### What changes were proposed in this pull request?
This PR switched the order for the rule `RemoveRedundantSorts` and `EnsureRequirements` so that `EnsureRequirements` will be invoked before `RemoveRedundantSorts` to avoid IllegalArgumentException when instantiating PartitioningCollection.
### Why are the changes needed?
`RemoveRedundantSorts` rule uses SparkPlan's `outputPartitioning` to check whether a sort node is redundant. Currently, it is added before `EnsureRequirements`. Since `PartitioningCollection` requires left and right partitioning to have the same number of partitions, which is not necessarily true before applying `EnsureRequirements`, the rule can fail with the following exception:
```
IllegalArgumentException: requirement failed: PartitioningCollection requires all of its partitionings have the same numPartitions.
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730850728
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35998/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730845979
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35998/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730823373
**[Test build #131394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131394/testReport)** for PR 30437 at commit [`dbc38d3`](https://github.com/apache/spark/commit/dbc38d371ea3615ac6e756ade27f6fdefafa1feb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730945642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730850742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30437:
URL: https://github.com/apache/spark/pull/30437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730943334
**[Test build #131394 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131394/testReport)** for PR 30437 at commit [`dbc38d3`](https://github.com/apache/spark/commit/dbc38d371ea3615ac6e756ade27f6fdefafa1feb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730823373
**[Test build #131394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131394/testReport)** for PR 30437 at commit [`dbc38d3`](https://github.com/apache/spark/commit/dbc38d371ea3615ac6e756ade27f6fdefafa1feb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730945642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30437: [SPARK-33472][SQL][2.4] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30437:
URL: https://github.com/apache/spark/pull/30437#issuecomment-730850742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org