[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3124: [WIP] ARTEMIS-2614 Create queues based on FQQN - AMQP

[GitBox <gi...@apache.org>]

michaelandrepearce edited a comment on pull request #3124:
URL: https://github.com/apache/activemq-artemis/pull/3124#issuecomment-633269335


   To be honest i would expect for FQQN it to apply all the exact logic thats in there, except the where we call createQueueName you use queueNameToUse if it present instead, that was possibly extracted earlier in the composite address extraction
   
   e.g. line 413
   
                  queue = createQueueName(connection.isUseCoreSubscriptionNaming(), clientId, pubId, shared, global, false);
   
   to 
   
                  queue = queueNameToUse == null ? createQueueName(connection.isUseCoreSubscriptionNaming(), clientId, pubId, shared, global, false) : queueNameToUse;
   
   
   And like wise line 438 extactly the same
   
   I wouldnt expect changes anywhere else to achieve what you wanted, e.g. no change to any other class or area of the code base, a very small extra if then else  around the queue name used


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org