You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "nicktelford (via GitHub)" <gi...@apache.org> on 2026/05/18 16:56:26 UTC
[PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
nicktelford opened a new pull request, #22315:
URL: https://github.com/apache/kafka/pull/22315
The cache holds uncommitted writes that must not be visible under
READ_COMMITTED, so that isolation level bypasses the cache entirely and
delegates straight to the inner store's readOnly view. READ_UNCOMMITTED
requires a merged view through a ReadOnlyView. The ReadOnlyView delegates
to the existing fetchInternal/fetchKeyRange/fetchAllInternal helpers and
converts Instant arguments to epoch-milliseconds before calling them;
the cache key schema operates in longs throughout, so converting early
avoids repeated Instant-to-long conversions in iterator hot paths.
KAFKA-20497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4479920091
@bbejeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck merged PR #22315:
URL: https://github.com/apache/kafka/pull/22315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4710391031
Merged #22315 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4634213589
Thanks @nicktelford - still getting the same test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4689722805
@bbejeck Sorry about that. It should be fixed for real now. I think the issue was a conflict with another PR, where both PRs were flip-flopping on the terminology in the same error message, and "fixing" one would then break the other post-merge :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4617004470
Thanks @nicktelford - looks good overall but there are some test failures which I think can be resolved by updating the log statement on line 526 is in `TimeOrderedCachingWindowStore`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4602860867
> Thanks @nicktelford - overall looks good but there are a couple of failing tests
>
> 1. `org.apache.kafka.streams.state.internals.TimeOrderedCachingPersistentWindowStoreTest#shouldThrowOnNullInstantInViewFetch`
> 2. `org.apache.kafka.streams.state.internals.TimeOrderedCachingPersistentWindowStoreTest#shouldNotThrowInvalidBackwardRangeExceptionWithNegativeFromKey`
@bbejeck Rebased on trunk; these test failures should now be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4623638377
@bbejeck I think I fixed this the other day but forgot to push the new commit :man_facepalming:
Also rebased on trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4606370882
@nicktelford - needs `./gradlew spotlessApply`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20497: Add TimeOrderedCachingWindowStore#readOnly [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22315:
URL: https://github.com/apache/kafka/pull/22315#issuecomment-4540047210
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org