[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #812: GEODE-9324: Remove ACE_Task refereces

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on a change in pull request #812:
URL: https://github.com/apache/geode-native/pull/812#discussion_r749424688



##########
File path: cppcache/integration-test/ThinClientSecurityHelper.hpp
##########
@@ -170,20 +170,20 @@ void initClientAuth(char UserType) {
   }
 }
 
-// This putThread class is used in
+// This PutThread class is used in
 // testThinClientTracking,testThinClientTicket304, testThinClientTicket317
 
-class putThread : public ACE_Task_Base {
+class PutThread {
  public:
-  explicit putThread(std::shared_ptr<Region> r, bool regInt = false,
-                     int waitTime = 0) {
-    m_reg = r;
-    m_regInt = regInt;
-    m_numthreads = 1;
-    m_numops = 0;
-    m_isCallBack = false;
-    m_sameKey = false;
-    m_waitTime = waitTime;
+  explicit PutThread(std::shared_ptr<Region> r, bool regInt = false,
+                     int waitTime = 0)
+      : m_reg{r},

Review comment:
       Often when refactoring things in a class these days, I will take a few minutes and rename the member variables to conform to the style guide.  Your call, just would be nice as long as you're in here mucking about.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org