You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/06/26 21:31:40 UTC
Review Request 23086: Update system check to unbundle protobuf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 429c956
3rdparty/libprocess/configure.ac 27c6ede
configure.ac 41f3c2b
mpi/mpiexec-mesos.in da0733f
src/Makefile.am 3c8b91a
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in 569519b
src/examples/python/test-executor.in 7e8875f
src/examples/python/test-framework.in c4683b9
src/python/setup.py.in b996dfe
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49681
-----------------------------------------------------------
Bad patch!
Reviews applied: [23086]
Failed command: git apply --index 23086.patch
Error:
error: patch failed: mpi/mpiexec-mesos.in:25
error: mpi/mpiexec-mesos.in: patch does not apply
error: patch failed: src/Makefile.am:44
error: src/Makefile.am: patch does not apply
error: patch failed: src/examples/python/test-containerizer.in:28
error: src/examples/python/test-containerizer.in: patch does not apply
error: patch failed: src/examples/python/test-executor.in:28
error: src/examples/python/test-executor.in: patch does not apply
error: patch failed: src/examples/python/test-framework.in:28
error: src/examples/python/test-framework.in: patch does not apply
error: patch failed: src/python/setup.py.in:73
error: src/python/setup.py.in: patch does not apply
- Mesos ReviewBot
On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 705d19c
> 3rdparty/libprocess/configure.ac 3a38b04
> configure.ac e747208
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am c216e2f
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 14, 2014, 4:10 a.m., Vinod Kone wrote:
> > LGTM. Go ahead and commit it. Thanks Time for your patience.
Tim*
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50547
-----------------------------------------------------------
On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50547
-----------------------------------------------------------
Ship it!
LGTM. Go ahead and commit it. Thanks Time for your patience.
- Vinod Kone
On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 1:21 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
update per review
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 497d038
3rdparty/libprocess/configure.ac 7b39e63
configure.ac 8fb0a3a
mpi/mpiexec-mesos.in 8812ee2
src/Makefile.am 0ac95b4
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in f71828d
src/examples/python/test-executor.in b22e7a7
src/examples/python/test-framework.in 64fb1dd
src/python/native/ext_modules.py.in 477e63d
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > <https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255>
> >
> > shouldn't this be different if we are using bundled "protoc" vs system installed "protoc"? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am.
> >
> > it was definitely a bit confusing to me, so maybe add a comment?
> >
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version?
> >
>
> Timothy St. Clair wrote:
> I updated the logic to make it similar to the others
>
> elif test "x$enable_bundled" = "xno"; then
> PROTOCOMPILER="protoc"
>
> and added a comment.
>
Let me know if you would like me to commit.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
-----------------------------------------------------------
On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > i'm assuming you tested this with all 3 configurations (bundled,system,prefix) like you did for gmock?
correct.
> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > <https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255>
> >
> > shouldn't this be different if we are using bundled "protoc" vs system installed "protoc"? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am.
> >
> > it was definitely a bit confusing to me, so maybe add a comment?
> >
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version?
> >
I updated the logic to make it similar to the others
elif test "x$enable_bundled" = "xno"; then
PROTOCOMPILER="protoc"
and added a comment.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
-----------------------------------------------------------
On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 7:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
-----------------------------------------------------------
Ship it!
i'm assuming you tested this with all 3 configurations (bundled,system,prefix) like you did for gmock?
configure.ac
<https://reviews.apache.org/r/23086/#comment88370>
shouldn't this be different if we are using bundled "protoc" vs system installed "protoc"? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am.
it was definitely a bit confusing to me, so maybe add a comment?
alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version?
- Vinod Kone
On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 7:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 7:46 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
rebased to origin/master
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 497d038
3rdparty/libprocess/configure.ac 7b39e63
configure.ac 8fb0a3a
mpi/mpiexec-mesos.in 8812ee2
src/Makefile.am 0ac95b4
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in f71828d
src/examples/python/test-executor.in b22e7a7
src/examples/python/test-framework.in 64fb1dd
src/python/native/ext_modules.py.in 477e63d
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50492
-----------------------------------------------------------
can you rebase?
- Vinod Kone
On Aug. 13, 2014, 7:28 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 7:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b
> 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6
> 3rdparty/libprocess/configure.ac 7b39e63
> 3rdparty/libprocess/include/process/defer.hpp ebe6f2d
> 3rdparty/libprocess/include/process/future.hpp 46ae16b
> 3rdparty/libprocess/src/process.cpp c2bee98
> configure.ac 8fb0a3a
> include/mesos/mesos.proto dc781d1
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 0ac95b4
> src/common/http.hpp afce7fe
> src/common/http.cpp 58050e9
> src/common/type_utils.cpp 78bfa94
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/health-check/main.cpp 6849947
> src/launcher/executor.cpp 64a4175
> src/master/http.cpp 6dd11fe
> src/master/master.cpp e948803
> src/python/native/ext_modules.py.in 477e63d
> src/slave/containerizer/mesos/launch.cpp 4e727a1
> src/slave/http.cpp 92eb348
> src/slave/slave.cpp 59477d5
> src/tests/common/http_tests.cpp 5fa51bf
> src/tests/health_check_tests.cpp 64fbf62
> src/tests/master_authorization_tests.cpp b9aa7bf
> src/tests/process_spawn.cpp PRE-CREATION
> src/tests/reconciliation_tests.cpp 8c66659
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 7:28 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
update from review to SUBST protoc and do a python check on google.protobuf.
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 497d038
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953
3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6
3rdparty/libprocess/configure.ac 7b39e63
3rdparty/libprocess/include/process/defer.hpp ebe6f2d
3rdparty/libprocess/include/process/future.hpp 46ae16b
3rdparty/libprocess/src/process.cpp c2bee98
configure.ac 8fb0a3a
include/mesos/mesos.proto dc781d1
mpi/mpiexec-mesos.in 8812ee2
src/Makefile.am 0ac95b4
src/common/http.hpp afce7fe
src/common/http.cpp 58050e9
src/common/type_utils.cpp 78bfa94
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in f71828d
src/examples/python/test-executor.in b22e7a7
src/examples/python/test-framework.in 64fb1dd
src/health-check/main.cpp 6849947
src/launcher/executor.cpp 64a4175
src/master/http.cpp 6dd11fe
src/master/master.cpp e948803
src/python/native/ext_modules.py.in 477e63d
src/slave/containerizer/mesos/launch.cpp 4e727a1
src/slave/http.cpp 92eb348
src/slave/slave.cpp 59477d5
src/tests/common/http_tests.cpp 5fa51bf
src/tests/health_check_tests.cpp 64fbf62
src/tests/master_authorization_tests.cpp b9aa7bf
src/tests/process_spawn.cpp PRE-CREATION
src/tests/reconciliation_tests.cpp 8c66659
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50395
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23086]
All tests passed.
- Mesos ReviewBot
On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 39af036
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 11, 2014, 9:16 p.m., Vinod Kone wrote:
> > src/examples/python/test-executor.in, lines 24-30
> > <https://reviews.apache.org/r/23086/diff/4/?file=657922#file657922line24>
> >
> > Here and in other example python scripts below, do you want to pass PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? I think that would be more cleaner?
> >
> >
So I've added a detection for the google.protobuf python module, but it doesn't install via prefix, it's a separate step. I've verified by checking the rpm & deb packages.
So we'll have to verify via PYTHONPATH.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
-----------------------------------------------------------
On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 39af036
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/23086/#comment87876>
Can you make sure to look in the user supplied protobuf path ("with_protobuf") for protoc? You might also want to do a AC_SUBST to pass it through.
src/examples/python/test-executor.in
<https://reviews.apache.org/r/23086/#comment87879>
Here and in other example python scripts below, do you want to pass PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? I think that would be more cleaner?
src/examples/python/test-executor.in
<https://reviews.apache.org/r/23086/#comment87880>
I think we should test whether protobuf is present on PYTHONPATH.
How about testing if "python -c 'import google.protobuf'" works?
Longer term, the idiomatic way of doing this seems to be using virtualenv/pip, but lets not worry about that in this review.
- Vinod Kone
On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 39af036
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/python/native/ext_modules.py.in 477e63d
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 7:11 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
rebase per request.
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 497d038
3rdparty/libprocess/configure.ac 7b39e63
configure.ac 8fb0a3a
mpi/mpiexec-mesos.in 8812ee2
src/Makefile.am 39af036
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in f71828d
src/examples/python/test-executor.in b22e7a7
src/examples/python/test-framework.in 64fb1dd
src/python/native/ext_modules.py.in 477e63d
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50207
-----------------------------------------------------------
can you rebase?
- Vinod Kone
On Aug. 8, 2014, 5:58 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 5:58 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 497d038
> 3rdparty/libprocess/configure.ac 7b39e63
> Doxyfile 8bba461
> configure.ac 8fb0a3a
> mpi/mpiexec-mesos.in 8812ee2
> src/Makefile.am 39af036
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in f71828d
> src/examples/python/test-executor.in b22e7a7
> src/examples/python/test-framework.in 64fb1dd
> src/master/hierarchical_allocator_process.hpp 34f8cd6
> src/master/master.cpp e688b41
> src/python/native/ext_modules.py.in 477e63d
> src/slave/constants.hpp 9030871
> src/slave/constants.cpp e1da5c0
> src/slave/containerizer/isolators/network/port_mapping.cpp 938782a
> src/slave/slave.cpp 787bd05
> src/tests/allocator_tests.cpp 774528a
> src/tests/health_check_tests.cpp 731d944
> src/tests/mesos.cpp 6b5c43f
> src/tests/port_mapping_tests.cpp a990da3
> support/timed_tests.sh e060966
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: MESOS-1174: Update system check to unbundle
protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 5:58 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
update from review.
Summary (updated)
-----------------
MESOS-1174: Update system check to unbundle protobuf
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 497d038
3rdparty/libprocess/configure.ac 7b39e63
Doxyfile 8bba461
configure.ac 8fb0a3a
mpi/mpiexec-mesos.in 8812ee2
src/Makefile.am 39af036
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in f71828d
src/examples/python/test-executor.in b22e7a7
src/examples/python/test-framework.in 64fb1dd
src/master/hierarchical_allocator_process.hpp 34f8cd6
src/master/master.cpp e688b41
src/python/native/ext_modules.py.in 477e63d
src/slave/constants.hpp 9030871
src/slave/constants.cpp e1da5c0
src/slave/containerizer/isolators/network/port_mapping.cpp 938782a
src/slave/slave.cpp 787bd05
src/tests/allocator_tests.cpp 774528a
src/tests/health_check_tests.cpp 731d944
src/tests/mesos.cpp 6b5c43f
src/tests/port_mapping_tests.cpp a990da3
support/timed_tests.sh e060966
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 303
> > <https://reviews.apache.org/r/23086/diff/2/?file=639448#file639448line303>
> >
> > instead of hardcoding the version, is there a way to get this from 3rdparty versions.am?
So autoconf feeds forward into automake. I don't know of a clean way to handle, unless it went through some common m4.
I'm hoping *this is temporary, and in next version we can remove this entirely and just check for protobuf, as it exists on nearly all platforms.
> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > configure.ac, line 347
> > <https://reviews.apache.org/r/23086/diff/2/?file=639449#file639449line347>
> >
> > instead of hardcoding the version, is there a way to get this from 3rdparty versions.am?
same as previous comment.
> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > src/Makefile.am, line 52
> > <https://reviews.apache.org/r/23086/diff/2/?file=639451#file639451line52>
> >
> > would this work if 'protoc' is installed in a prefix location?
Added a hard check in configure, it should be in the path.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49532
-----------------------------------------------------------
On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 705d19c
> 3rdparty/libprocess/configure.ac 3a38b04
> configure.ac e747208
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am c216e2f
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49532
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/23086/#comment86638>
This is done below in lines 215 and 216. Doesn't look it's need here?
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/23086/#comment86643>
what happens if "protobuf.jar" doesn't exist in this location? where/when does the error occur?
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/23086/#comment86676>
instead of hardcoding the version, is there a way to get this from 3rdparty versions.am?
configure.ac
<https://reviews.apache.org/r/23086/#comment86675>
instead of hardcoding the version, is there a way to get this from 3rdparty versions.am?
mpi/mpiexec-mesos.in
<https://reviews.apache.org/r/23086/#comment86672>
Maybe also mention to ensure that the protobuf egg exists on the PYTHONPATH? Otherwise users would've no idea how to go forward.
src/Makefile.am
<https://reviews.apache.org/r/23086/#comment86645>
would this work if 'protoc' is installed in a prefix location?
src/examples/python/test-containerizer.in
<https://reviews.apache.org/r/23086/#comment86678>
ditto. expand on the comment.
src/examples/python/test-executor.in
<https://reviews.apache.org/r/23086/#comment86679>
ditto. expand on the comment.
src/examples/python/test-framework.in
<https://reviews.apache.org/r/23086/#comment86680>
ditto. expand on the comment.
- Vinod Kone
On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 705d19c
> 3rdparty/libprocess/configure.ac 3a38b04
> configure.ac e747208
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am c216e2f
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated July 22, 2014, 6:14 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Update for review, and tested on prefixed installation.
The JAR is a needs to be supplied on PREFIX, due to installation constraints.
The EGG is similar but is a runtime PYTHONPATH imho, and errors should be reported.
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 705d19c
3rdparty/libprocess/configure.ac 3a38b04
configure.ac e747208
mpi/mpiexec-mesos.in da0733f
src/Makefile.am c216e2f
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in 569519b
src/examples/python/test-executor.in 7e8875f
src/examples/python/test-framework.in c4683b9
src/python/setup.py.in b996dfe
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
-----------------------------------------------------------
(Updated July 22, 2014, 4:54 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
assigning myself as shepherd -- vinodkone.
Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174
Repository: mesos-git
Description
-------
Enable mesos to build against system installed version of protobuf.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 429c956
3rdparty/libprocess/configure.ac 27c6ede
configure.ac 41f3c2b
mpi/mpiexec-mesos.in da0733f
src/Makefile.am 3c8b91a
src/examples/java/test-exception-framework.in 065f3c0
src/examples/java/test-executor.in 35559d2
src/examples/java/test-framework.in 9af48f9
src/examples/java/test-log.in 8afed0d
src/examples/java/test-multiple-executors-framework.in 235eb23
src/examples/python/test-containerizer.in 569519b
src/examples/python/test-executor.in 7e8875f
src/examples/python/test-framework.in c4683b9
src/python/setup.py.in b996dfe
Diff: https://reviews.apache.org/r/23086/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > configure.ac, line 315
> > <https://reviews.apache.org/r/23086/diff/1/?file=618608#file618608line315>
> >
> > would PKG_CHECK_MODULES work if protobuf is installed in a non-standard location that user specified with --with-protobuf=<dir>?
Added the check above on prefix.
> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/java/test-exception-framework.in, line 18
> > <https://reviews.apache.org/r/23086/diff/1/?file=618611#file618611line18>
> >
> > What happens when the user gives --with-protobuf=/path/to/non-standard/location?
> >
> > is the jar still expected in /usr/share/java?
> >
> > is it possible to plumb through the user provided protobuf path to these scripts? that seems better than silently trying to pick the jar from a standard location?
Overloaded to use AC_SUBST
> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/python/test-framework.in, line 31
> > <https://reviews.apache.org/r/23086/diff/1/?file=618618#file618618line31>
> >
> > ditto. saying "failed" and proceeding seems weird. is the egg expected to be on the python path? if yes, we should at least tell the users so?
This actually doesn't matter so much as they user can adjust their PYTHONPATH. For 99% of cases where folks will use the system installation of protobuf, this is a non-issue.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
-----------------------------------------------------------
On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:31 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> configure.ac 41f3c2b
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am 3c8b91a
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/java/test-exception-framework.in, line 18
> > <https://reviews.apache.org/r/23086/diff/1/?file=618611#file618611line18>
> >
> > What happens when the user gives --with-protobuf=/path/to/non-standard/location?
> >
> > is the jar still expected in /usr/share/java?
> >
> > is it possible to plumb through the user provided protobuf path to these scripts? that seems better than silently trying to pick the jar from a standard location?
>
> Timothy St. Clair wrote:
> Overloaded to use AC_SUBST
The logic for this is weird due to: https://lists.gnu.org/archive/html/bug-autoconf/2013-02/msg00008.html
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
-----------------------------------------------------------
On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:31 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> configure.ac 41f3c2b
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am 3c8b91a
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/23086/#comment84305>
end with period.
configure.ac
<https://reviews.apache.org/r/23086/#comment84336>
would PKG_CHECK_MODULES work if protobuf is installed in a non-standard location that user specified with --with-protobuf=<dir>?
mpi/mpiexec-mesos.in
<https://reviews.apache.org/r/23086/#comment84321>
period at the end.
src/examples/java/test-exception-framework.in
<https://reviews.apache.org/r/23086/#comment84333>
What happens when the user gives --with-protobuf=/path/to/non-standard/location?
is the jar still expected in /usr/share/java?
is it possible to plumb through the user provided protobuf path to these scripts? that seems better than silently trying to pick the jar from a standard location?
src/examples/python/test-framework.in
<https://reviews.apache.org/r/23086/#comment84335>
ditto. saying "failed" and proceeding seems weird. is the egg expected to be on the python path? if yes, we should at least tell the users so?
- Vinod Kone
On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:31 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> configure.ac 41f3c2b
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am 3c8b91a
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 22, 2014, 1:41 a.m., Vinod Kone wrote:
> > forgot to update the diff?
Nope I just wanted to do full builds on a couple of machines prior to submit.
... Takes a long time.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48325
-----------------------------------------------------------
On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:31 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> configure.ac 41f3c2b
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am 3c8b91a
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23086: Update system check to unbundle protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48325
-----------------------------------------------------------
forgot to update the diff?
- Vinod Kone
On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:31 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against system installed version of protobuf.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> configure.ac 41f3c2b
> mpi/mpiexec-mesos.in da0733f
> src/Makefile.am 3c8b91a
> src/examples/java/test-exception-framework.in 065f3c0
> src/examples/java/test-executor.in 35559d2
> src/examples/java/test-framework.in 9af48f9
> src/examples/java/test-log.in 8afed0d
> src/examples/java/test-multiple-executors-framework.in 235eb23
> src/examples/python/test-containerizer.in 569519b
> src/examples/python/test-executor.in 7e8875f
> src/examples/python/test-framework.in c4683b9
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23086/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>