[GitHub] rabbah commented on a change in pull request #2831: Make console tests more robust

[gi...@git.apache.org]

rabbah commented on a change in pull request #2831: Make console tests more robust
URL: https://github.com/apache/incubator-openwhisk/pull/2831#discussion_r142745610
 
 

 ##########
 File path: tests/src/test/scala/system/basic/WskConsoleTests.scala
 ##########
 @@ -61,31 +65,46 @@ class WskConsoleTests extends TestHelpers with WskTestHelpers {
       action.create(fullActionName, Some(TestUtils.getTestActionFilename("hello.js")))
     }
 
-    val duration = Some(30 seconds)
+    val duration = 30 seconds
     val payload = new String("from the console!".getBytes, "UTF-8")
     val run = wsk.action.invoke(fullActionName, Map("payload" -> payload.toJson))
-    withActivation(wsk.activation, run, totalWait = duration.get) { activation =>
-      val console = wsk.activation.console(10 seconds, since = duration)
-      console.stdout should include(payload)
+    withActivation(wsk.activation, run, totalWait = duration) { activation =>
+      val pollTime = 10 seconds
+      val console = wsk.activation.console(pollTime, since = Some(duration))
 
 Review comment:
   should the duration here used in `since` actually account for the activation start time?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services