[jira] [Commented] (TEZ-2911) Null location Strings can cause problems with GroupedSplit serialization

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053219#comment-15053219 ] 

TezQA commented on TEZ-2911:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12776988/TEZ-2911.2.txt
  against master revision 460e0b2.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.app.dag.impl.TestVertexImpl

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/1363//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/1363//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1363//console

This message is automatically generated.

> Null location Strings can cause problems with GroupedSplit serialization
> ------------------------------------------------------------------------
>
>                 Key: TEZ-2911
>                 URL: https://issues.apache.org/jira/browse/TEZ-2911
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Minor
>         Attachments: TEZ-2911.1.txt, TEZ-2911.2.txt
>
>
> If the location is a non-null array, and one of the elements is null, and the GroupedSplit is the same as the raw split - the groupedSplit throws an NPE during serialization.
> This isn't necessarily a bug - since the original split location should not be null. However, there's parts of the code which ignore such null locations (and there's a test for this), while others don't. This should be done consistently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)