You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/07 15:35:59 UTC
[GitHub] [superset] geido opened a new pull request #12330: fix: Select shows behind Antd popover
geido opened a new pull request #12330:
URL: https://github.com/apache/superset/pull/12330
### SUMMARY
The Antd Popover has a z-index at 1030. By adding the option `menuPortalTarget` as `document.body` to the Select, the dropdowns (both single-choice and multi-choice) show behind the Popover. One fix could have been to reduce the default z-index of the Antd Popover but we don't know what side effects this might cause. This PR instead raises the z-index of the outer div of the dropdowns to be the same as the Antd Popover. This should be a safer approach as dropdowns must usually appear over elements.
Closes #12309
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
### TEST PLAN
1. Create a new Scatterplot chart
2. Click to set latitude and longitude under "Query"
3. Click on "Latitude" and "Longitude" Select. The. dropdowns should be visible
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12309
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12330: fix: Select shows behind Antd popover
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12330:
URL: https://github.com/apache/superset/pull/12330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #12330: fix: Select shows behind Antd popover
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12330:
URL: https://github.com/apache/superset/pull/12330#issuecomment-756191047
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org