You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "xujiantop-crypto (via GitHub)" <gi...@apache.org> on 2026/09/10 02:49:18 UTC
[PR] orchestration: apply custom IOPS to root volumes [cloudstack]
xujiantop-crypto opened a new pull request, #14114:
URL: https://github.com/apache/cloudstack/pull/14114
## Summary
Custom root disk IOPS are stored in VM details as `minIops` and `maxIops`. `CloudOrchestrator` was reading the API parameter names `miniops` and `maxiops`, so the values were not propagated to the root `DiskOfferingInfo` during VM deployment from a template.
This change:
- adds canonical VM-detail constants for `minIops` and `maxIops`
- uses those constants when building the root disk offering
- adds a regression test that verifies custom root IOPS reach the VM allocation call
Fixes #14103
## Testing
```text
mvn -pl engine/orchestration -am -Dtest=CloudOrchestratorTest -DfailIfNoTests=false test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
33/33 reactor modules SUCCESS
Checkstyle: 0 violations
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#discussion_r4388363452
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java:
##########
@@ -199,8 +197,8 @@ public VirtualMachineEntity createVirtualMachine(String id, String owner, String
Map<String, String> userVmDetails = _userVmDetailsDao.listDetailsKeyPairs(vm.getId());
if (userVmDetails != null) {
- String minIops = userVmDetails.get(MIN_IOPS);
- String maxIops = userVmDetails.get(MAX_IOPS);
+ String minIops = userVmDetails.get(VmDetailConstants.MIN_IOPS);
Review Comment:
the check that stops a min above max on deploy is in UserVmManagerImpl, and it still looks up miniops and maxiops. i suggest it reads the new minIops and maxIops names too, so a bad pair errors out instead of reaching the volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#discussion_r4205875985
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java:
##########
@@ -199,8 +197,8 @@ public VirtualMachineEntity createVirtualMachine(String id, String owner, String
Map<String, String> userVmDetails = _userVmDetailsDao.listDetailsKeyPairs(vm.getId());
if (userVmDetails != null) {
- String minIops = userVmDetails.get(MIN_IOPS);
- String maxIops = userVmDetails.get(MAX_IOPS);
+ String minIops = userVmDetails.get(VmDetailConstants.MIN_IOPS);
Review Comment:
should the min and max check on deploy use these new names too? it still looks up the old ones, so a min above max now reaches the volume without an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#issuecomment-5614613937
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/14114?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.14%. Comparing base ([`6e4413d`](https://app.codecov.io/gh/apache/cloudstack/commit/6e4413d59b771d770dca6aa74d4454016b65f720?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`41acb91`](https://app.codecov.io/gh/apache/cloudstack/commit/41acb91f92663338ebbcf1f1aefaf33daad64f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (6e4413d) and HEAD (41acb91). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (6e4413d) | HEAD (41acb91) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #14114 +/- ##
=============================================
- Coverage 16.36% 4.14% -12.23%
=============================================
Files 5669 405 -5264
Lines 501475 33073 -468402
Branches 60913 5903 -55010
=============================================
- Hits 82067 1370 -80697
+ Misses 410209 31527 -378682
+ Partials 9199 176 -9023
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/14114/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/14114/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.14% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/14114/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/14114?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#issuecomment-6034880878
tested by reporter (see https://github.com/apache/cloudstack/issues/14103#issuecomment-6019272154)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "rajiv-jain-netapp (via GitHub)" <gi...@apache.org>.
rajiv-jain-netapp commented on PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#issuecomment-5727900265
can you put some UI screenshots where you find these workflows working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] orchestration: apply custom IOPS to root volumes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#discussion_r4387603182
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java:
##########
@@ -199,8 +197,8 @@ public VirtualMachineEntity createVirtualMachine(String id, String owner, String
Map<String, String> userVmDetails = _userVmDetailsDao.listDetailsKeyPairs(vm.getId());
if (userVmDetails != null) {
- String minIops = userVmDetails.get(MIN_IOPS);
- String maxIops = userVmDetails.get(MAX_IOPS);
+ String minIops = userVmDetails.get(VmDetailConstants.MIN_IOPS);
Review Comment:
@Damans227 what change are you suggesting (if any)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org